1660897 - The context selector flashes many times and is making the browser toolbox slow/crash

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Alexandre Poirot [:ochameau]]

EvaluationContextSelector React component would benefit from having a shouldComponentUpdate or any other mechanism in order to avoid doing too many DOM mutations.
Today, anytime anythink change in the related store, the DOM will be rerendered.
This makes the selector blink and slows down the Browser toolbox a lot if you have many such updates.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1660897 - Avoid updating the JS context selector too many times.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d00e750578a
Avoid updating the JS context selector too many times. r=nchevobbe

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2d00e750578a