Closed Bug 1660897 Opened 4 years ago Closed 4 years ago

The context selector flashes many times and is making the browser toolbox slow/crash

Categories

(DevTools :: Framework, enhancement)

Product:
DevTools
Component:
Framework
Type:
enhancement

Tracking

(Fission Milestone:M6c, firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Project Flags:
Fission Milestone M6c
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1660897 - Avoid updating the JS context selector too many times.
47 bytes, text/x-phabricator-request
Details | Review

EvaluationContextSelector React component would benefit from having a shouldComponentUpdate or any other mechanism in order to avoid doing too many DOM mutations.
Today, anytime anythink change in the related store, the DOM will be rerendered.
This makes the selector blink and slows down the Browser toolbox a lot if you have many such updates.

Assignee: nobody → poirot.alex

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: General → Framework
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d00e750578a
Avoid updating the JS context selector too many times. r=nchevobbe

https://hg.mozilla.org/mozilla-central/rev/2d00e750578a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Fission Milestone: --- → M6c
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: