1660909 - Crash in nsIPrinterList::GetNamedOrDefaultPrinter with non-first printer name

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect, P1)

Description

[Emily McDonough [:alaskanemily]]

nsIPrinterList::GetNamedOrDefaultPrinter will crash on CUPS platforms (OS X, Linux, BSD, etc) when given a printer name which is present in the printer list, but is not the first one in the list.

The crash is present in the 81 branch.

Comment 1

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1660909 - Fix a crash in NamedPrinter on CUPS

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e746a73dfec
Fix a crash in NamedPrinter on CUPS r=emilio

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4e746a73dfec

Comment 4

[Jonathan Watt [:jwatt]]

Reminder to request beta approval. We probably won't use this, but having it on beta keeps our options open.

Comment 5

[Emily McDonough [:alaskanemily]]

Comment on attachment 9171825 [details]
Bug 1660909 - Fix a crash in NamedPrinter on CUPS

Beta/Release Uplift Approval Request

• User impact if declined: Further code for the new print UI that is uplifted may cause crashes on non-Windows platforms.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is extremely self-contained, and development of further changes for the new print UI that occur on nightly is being done with it already in place.
• String changes made/needed:

Comment 6

[Emily McDonough [:alaskanemily]]

The problem can be observed on OS X or Linux by running the following in the browser console:

Cc["@mozilla.org/gfx/printerlist;1"].getService(
    Ci.nsIPrinterList
).printers.then(
  function(ps){
    if(ps.length < 2){
      console.log("You need two printers to test.");
    }
    else{
      Cc["@mozilla.org/gfx/printerlist;1"].getService(
        Ci.nsIPrinterList
      ).getNamedOrDefaultPrinter(ps[1].QueryInterface(Ci.nsIPrinter).name).then(
      function(){ console.log("OK"); });
  }
});

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9171825 [details]
Bug 1660909 - Fix a crash in NamedPrinter on CUPS

Approved for 81.0b4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fe3db72b3439