1660918 - Fix nsIPrintSettings.clone() to copy all members

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect, P2)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1660918. Fix nsIPrintSettings.clone() to copy all members. r=nordzilla

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21925e313c1f
Fix nsIPrintSettings.clone() to copy all members. r=nordzilla

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/21925e313c1f

Comment 4

[Jonathan Watt [:jwatt]]

Comment on attachment 9171826 [details]
Bug 1660918. Fix nsIPrintSettings.clone() to copy all members. r=nordzilla

Beta/Release Uplift Approval Request

• User impact if declined: Printing project blocker.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This code is not currently exercised, but once the frontend starts using it it just means we don't forget to copy some data members when cloning.
• String changes made/needed:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9171826 [details]
Bug 1660918. Fix nsIPrintSettings.clone() to copy all members. r=nordzilla

Approved for 81.0b2.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/81f998ce34f1