1660968 - Remove uses of GetInProcessScriptableTop in WebSocketImpl::GetLoadingPrincipal

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P1)

Description

[Valentin Gosu [:valentin] (he/him)]

+++ This bug was initially created as a clone of Bug #1646545 +++

It's used in a bunch of places, mostly (though not always) just to get the top inner window ID. That can be done (and more correctly) using WindowContext instead. I'm not sure what needs to happen with the other uses.

Code link

Comment 1

[Andrea Marchesini [:baku]]

This code has to be removed/changed for fission. I suspect that the work for window.name could be useful here.
I suggest adding a 'has-opener' boolean flag in Window context. Tim, does it make sense to you? And does the window.name work be useful here?

Comment 2

[Tim Huang[:timhuang]]

It makes sense to me to add a has-opener boolean flag in window context. And I guess we will implement this in bug 444222 because we want to know if a window has an opener regardless if the opener has been set by script.

Comment 3

[Kris Maglione [:kmag]]

Note: The GetInProcessScriptableTop usage in this function can probably just be changed to parentWindow->BrowsingContext()->Top() == innerWindow->GetBrowsingContext()->Top(). The GetInProcessScriptableParent() usage may be Fission-compatible, but it's somewhat unusual, so I'm not sure.

Comment 4

[Neha Kochar [:neha]]

Jens, this is P1. Please find an owner for this and fixing this for M6c soon.

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1660968 - Remove uses of GetInProcessScriptableTop in WebSocketImpl::GetLoadingPrincipal r=baku

This change also simplifies the code a bit.
Also, as BrowsingContext::GetOpener returns null when there's no opener,
we don't have to check whether the opener and innerWindow are the same.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/363cbf5310a8
Remove uses of GetInProcessScriptableTop in WebSocketImpl::GetLoadingPrincipal r=baku

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/363cbf5310a8

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.