1660983 - Warp: some AddSlot optimizations

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

• We can get rid of the group guard if TI is disabled.
• The "add function .prototype" optimization depends on interpreted-function ObjectGroups and no longer works without TI. This was a pretty significant win because it avoids an object allocation (bug 1336579 comment 3) so we should fix that to not depend on TI.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1660983 part 1 - Remove unnecessary holderId variable in tryAttachAddSlotStub. r?evilpie!

holderId was used for unboxed object expando properties.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1660983 part 2 - Make the function.prototype AddSlot optimization not depend on TI. r?evilpie!

This makes the optimization work with Warp.

Also stop emitting GuardGroup if TI is disabled.

Depends on D88129

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1660983 part 3 - Don't turn prototypes into singletons if TI is disabled. r?evilpie!

Just a drive-by change for something I noticed.

Depends on D88130

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b3331ff39f4
part 1 - Remove unnecessary holderId variable in tryAttachAddSlotStub. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/f9d5521819eb
part 2 - Make the function.prototype AddSlot optimization not depend on TI. r=evilpie
https://hg.mozilla.org/integration/autoland/rev/6a146cf8deb2
part 3 - Don't turn prototypes into singletons if TI is disabled. r=evilpie

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3b3331ff39f4
https://hg.mozilla.org/mozilla-central/rev/f9d5521819eb
https://hg.mozilla.org/mozilla-central/rev/6a146cf8deb2