1660993 - nsPrintSettingsWin::InitWithInitializer should reset the DEVMODE scale like nsPrintSettingsWin::CopyFromNative

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect, P1)

Description

[Bob Owen (:bobowen)]

I just spotted that I removed the resetting of dmScale in the DEVMODE in nsPrintSettingsWin::InitWithInitializer.

I only realised late on that it made sense to store the DEVMODE in that function, so we should reset like in nsPrintSettingsWin::CopyFromNative in case this DEVMODE gets used to set up the printer.

Comment 1

[Bob Owen (:bobowen)]

Attachment: Bug 1660993: Reset dmScale in nsPrintSettingsWin::InitWithInitializer. r=jwatt!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75dc13363021
Reset dmScale in nsPrintSettingsWin::InitWithInitializer. r=jwatt

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/75dc13363021

Comment 4

[Jonathan Watt [:jwatt]]

Reminder to request beta uplift.

Comment 5

[Bob Owen (:bobowen)]

Comment on attachment 9171927 [details]
Bug 1660993: Reset dmScale in nsPrintSettingsWin::InitWithInitializer. r=jwatt!

Beta/Release Uplift Approval Request

• User impact if declined: Required for new Printing UI to prevent potential print scaling issues.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1660986
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small refactor and simple change to add line already in existing similar code.
• String changes made/needed: None

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9171927 [details]
Bug 1660993: Reset dmScale in nsPrintSettingsWin::InitWithInitializer. r=jwatt!

approved for 81.0b3

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/91f9264055a7