1660994 - The “Open a new tab” button and the “File” toolbar button are barely visible when “Firefox Alpenglow” theme is enabled on Windows “Light” OS Theme

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Robert Martin [:romartin], Ecosystem QA]

Attachment: 2020-08-25_12h25_26.gif

[Affected Versions]:

• Firefox Beta 81.0b1 (Build ID: 20200824150741)
• Firefox Nightly 82.0a1 (Build ID: 20200824215021)

[Affected Platforms]:

• Windows 7 (x32)
• Windows 10 (x64)
• Ubuntu Linux 18.04

[Prerequisites]:

• Have the OS theme set to “Light”.
• Have the “Menu Bar” enabled.

[Steps to reproduce]:

1. Start the Firefox Browser with the profile from prerequisites.
2. Navigate to the "about:welcome" page.
3. Click the “Start Setup” button.
4. Click the “Not now” button.
5. Select “Firefox Alpenglow” theme.
6. Open 10 “New Tab” pages and observe the “Open a new tab” button.
7. Observe the “File” toolbar button.

[Expected results]:
6. The “Open a new tab” button is visible.
7. The “File” toolbar button is visible.

[Actual results]:
6. The “Open a new tab” button is barely visible.
7. The “File” toolbar button is barely visible.

[Notes]:

• The issue is also reproducible on Ubuntu Linux 18.04.
• The issue is not reproducible on macOS 10.15.
• Attached a recording of the issue.

Comment 1

[Tim Spurway [:tspurway]]

:shorlander, could you look at this one?

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

I talked to shorlander about this bug when we were working on bug 1661010. He said that it was going to be hard to make this be good in all the various possible configurations. He did make some changes that made it somewhat better, and those landed with bug 1661010. They can be tested in current nightlies.

We might want to make it even better at some point, but this seems reasonable for now.

Comment 3

[Robert Martin [:romartin], Ecosystem QA]

I have verified that the "File" toolbar button and the "Open a new tab" button are visible with the "Light" OS theme enabled by following the steps provided in the description using Firefox Nightly 82.0a1 (Build ID: 20200915092930) on Windows 10 x64 and Ubuntu Linux 18.04.

Comment 4

[Robert Martin [:romartin], Ecosystem QA]

Marking this issue as VERIFIED based on the verifications done in comment 14 from bug 1661010.