1661022 - trailing slash on --find-links pypi.*/pub ?

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, enhancement)

Description

[:dhouse]

Based on the logging and suggestions from :gcox in https://bugzilla.mozilla.org/show_bug.cgi?id=1580652#c51, would adding the trailing slash here will reduce the redirects from pypi/pub to pypi/pub/ ? I'm assuming this is the mozharness used by most tasks/workers and that they use the default.

https://searchfox.org/mozilla-central/source/testing/mozharness/mozharness/base/python.py#64

Comment 1

[Aki Sasaki (not active)]

Yes. I see 2 places in gecko: https://searchfox.org/mozilla-central/search?q=pypi.pub.build.mozilla.org&path=
I also see 2 places in ronin_puppet: https://github.com/mozilla-platform-ops/ronin_puppet/search?q=pypi.pub.build.mozilla.org%2Fpub&unscoped_q=pypi.pub.build.mozilla.org%2Fpub

Two places in puppetagain, but I'm not sure how much we use it: https://github.com/mozilla-releng/build-puppet/search?q=pypi.pub.build.mozilla.org%2Fpub&unscoped_q=pypi.pub.build.mozilla.org%2Fpub

Comment 2

[Aki Sasaki (not active)]

Attachment: Bug 1661022 - add trailing slash to pypi.pub.b.m.o/pub r=#releng-reviewers

Comment 3

[Aki Sasaki (not active)]

Attachment: [ronin_puppet] add trailing slash

Comment 4

[Aki Sasaki (not active)]

Attachment: [puppetagain] add trailing slash

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd9e932dca8b
add trailing slash to pypi.pub.b.m.o/pub r=releng-reviewers,bhearsum DONTBUILD

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fd9e932dca8b

Comment 7

[:dhouse]

Comment on attachment 9171988 [details] [review]
[ronin_puppet] add trailing slash

r+'d and merged in ronin puppet for macos hw workers

Comment 8

[Aki Sasaki (not active)]

I think that's everything. We could uplift the central patch to beta/esr if wanted.

Comment 9

[Aki Sasaki (not active)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d96bfdc5a86237c7cdd1ff1e02c9963d8355267f
https://hg.mozilla.org/releases/mozilla-esr78/rev/a37580e43f7ab597900c4584c1ac9273c7194487