Bump cc-rs to 1.0.48 (at least) in firefox (and backport to ESR)
Categories
(Firefox Build System :: General, defect, P3)
Tracking
(firefox84 fixed)
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: mail, Assigned: rstewart)
Details
(Keywords: in-triage)
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0
Steps to reproduce:
Bulding latest ESR in riscv64 fails because of missing bits from cc-rs 1.0.48 (https://github.com/alexcrichton/cc-rs/compare/1.0.48...master)
Expected results:
Bumping it to 1.0.48 makes firefox to compile it properly
|
||
Updated•4 years ago
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Updating to the latest cc seems generally useful even outside the context of riscv, and the change seems low-risk anyway, so we might as well do this.
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
•
|
||
Marco, can you please verify that if you apply the patch atop your checkout of ESR, you can build on your riscv machine? (I'm not able to reproduce because I don't have a riscv machine.)
|
||
Comment 4•4 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:rstewart, could you have a look please?
For more information, please visit auto_nag documentation.
|
Reporter | |
Comment 6•4 years ago
|
||
Sorry for late reply, however that change is enough for the rust compiler.
However, we would also need this patch to get mozjs to compile in riscv64:
I would be happy to submit that as well, however that's probably not enough to compile whole firefox, but just its JS engine.
|
|
Assignee | |
Comment 7•4 years ago
|
||
Ah. That's a different thing, then. Can you file a new bug for that and submit the patch for review? I'm not sure it'll be a candidate for backporting into ESR but if the patch is accepted then we can discuss that.
|
||
Comment 8•4 years ago
|
||
The parts of that patch not addressed in this one were addressed in bug 1318905
Pushed by rstewart@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c4293aba9f6 Update `cc` crate to v1.0.59 r=mhentges,dmajor
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
Description
•