Closed Bug 1661158 Opened 4 years ago Closed 4 years ago

Startup crash in Fenix when substituting a local GeckoView, after GeckoView rebuild with JVM-only changes

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

defect

Tracking

(firefox82 fixed)

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1657190 is very clever: it handles the situation when only one of the JNI libraries in GeckoView changes (by updating all of the JNI libraries). It's not that clever, though: it doesn't handle the situation when none of the JNI libraries changes. That's what happens when you make a JVM-only change.

To fix this, we should mix the hash of the JVM code into the library generation ID that Bug 1657190 added.

Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31ced0afd45e
Include hash of JVM inputs when working around Android-Gradle plugin bug substituting GeckoView. r=agi,geckoview-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Depends on: 1657190
Regressions: 1661406
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: