Closed Bug 1661234 Opened 3 years ago Closed 3 years ago

Remove head_search.js useTestEngines in favour of SearchTestUtils.useTestEngines

Categories

(Firefox :: Search, task, P2)

Product:
Firefox
Component:
Search
Type:
task
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
82 Branch
Iteration:
82.1 - Aug 24 - Sep 6
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Bug 1661234 - Remove useTestEngines from head_search.js, use SearchTestUtils version instead. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review
Bug 1661234 - Simplify head_search.js' readJSONFile. r?daleharvey!
47 bytes, text/x-phabricator-request
Details | Review

We currently have two implementations of useTestEngines - I think we should just consolidate on the SearchTestUtils version.

Rather than using NetUtils, we can swap to OS.File.read and TextDecoder().

Depends on D88273

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a13258fbd51
Remove useTestEngines from head_search.js, use SearchTestUtils version instead. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/f16918c10a6b
Simplify head_search.js' readJSONFile. r=daleharvey
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d8e8744729e1
Remove useTestEngines from head_search.js, use SearchTestUtils version instead. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/8da488a82f50
Simplify head_search.js' readJSONFile. r=daleharvey

https://hg.mozilla.org/mozilla-central/rev/d8e8744729e1
https://hg.mozilla.org/mozilla-central/rev/8da488a82f50

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.