1661272 - In-content UX and add-ons have very small fonts

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

Current Nightly, Linux, widget.disable-native-theme-for-content = true

about:downloads (and likely similar pages) and add-ons (such as uBlock Origin) have very small fonts now, likely a new regression from non-native theming changes.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Inspector indicates the font size changed from 14.66px to 13px.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

So this is because we are using the theme there, and we're forcing all the system font sizes to be effectively default-font-size - 3px (which is 13px in your case).

I think we should limit it to the fonts we care about.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1656264

Comment 4

[Stephen A Pohl [:spohl] (OOO until 3/20)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

So this is because we are using the theme there, and we're forcing all the system font sizes to be effectively default-font-size - 3px (which is 13px in your case).

I think we should limit it to the fonts we care about.

What fonts would this be? The UX spec expects form elements to have a font size of 13px. It seems to me that this is irrespective of the actual font chosen. Ideally, we could adjust the font size if:

1. The font is used in a form control;
2. The form control isn't CSS styled;
3. The form control does not have a custom font size specified.

I am not sure if we can currently achieve this. If this isn't possible, we might have to consider leaving the default font size alone. This would be a question for UX at that point...

Comment 5

[Emilio Cobos Álvarez [:emilio]]

These are the fonts used in form controls: https://searchfox.org/mozilla-central/search?q=font%3A&path=forms.css&case=false&regexp=false

-moz-fixed is just monospace, which also defaults to 13px if not overridden, so that's fine. So it seems just reducing the size of the -moz-field, -moz-button and -moz-list fonts is what you want, isn't it?

Comment 6

[Stephen A Pohl [:spohl] (OOO until 3/20)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

These are the fonts used in form controls: https://searchfox.org/mozilla-central/search?q=font%3A&path=forms.css&case=false&regexp=false

-moz-fixed is just monospace, which also defaults to 13px if not overridden, so that's fine. So it seems just reducing the size of the -moz-field, -moz-button and -moz-list fonts is what you want, isn't it?

Right, I'm not clear on how to achieve this though. As far as I know, we can't adjust the size in forms.css without impacting native themes too and I believe that when we compute system fonts in nsLayoutUtils, it is irrespective of where the font is used. Where do you suggest we adjust the font size?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

You have the font id in ComputeSystemFont, which should allow you to distinguish those fonts right?

https://searchfox.org/mozilla-central/rev/0c682c4f01442c3de0fa6cd286e9cadc8276b45f/layout/base/nsLayoutUtils.cpp#10359

Comment 8

[Emilio Cobos Álvarez [:emilio]]

That is, I think you just need an extra condition in the current if.

Comment 9

[Stephen A Pohl [:spohl] (OOO until 3/20)]

Attachment: Bug 1661272: Only adjust default font sizes for buttons, lists and fields when non-native theming is enabled. r=emilio

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7068c52a19cb
Only adjust default font sizes for buttons, lists and fields when non-native theming is enabled. r=emilio

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7068c52a19cb