Closed Bug 1661382 Opened 1 year ago Closed 1 year ago

Remove print modal header and footer semantics for a11y

Categories

(Toolkit :: Printing, defect, P3)

defect

Tracking

()

VERIFIED FIXED
82 Branch
Tracking Status
firefox81 --- verified
firefox82 --- verified

People

(Reporter: Jamie, Assigned: Jamie)

References

(Blocks 1 open bug)

Details

(Keywords: access, Whiteboard: [access-s4])

Attachments

(1 file)

Semantics are normally a good thing. However, the print dialog is small enough that having the header and footer semantics doesn't really help the user with navigation and serves only to add extraneous verbosity for screen reader users.

STR (with the NVDA screen reader):

  1. Open the print modal.
  2. Tab to the print button.
    • Expected: NVDA should say "Print button"
    • Actual: NVDA says "content info landmark, Print button"
Severity: -- → S4
Priority: -- → P3
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5712417ee27
Remove header and footer a11y semantics for print modal. r=mstriemer
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Do you want to request Beta uplift for this?

Flags: needinfo?(jteh)

Comment on attachment 9172308 [details]
Bug 1661382: Remove header and footer a11y semantics for print modal.

Beta/Release Uplift Approval Request

  • User impact if declined: Unnecessary screen reader verbosity in new print modal.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simply adds (well understood) attributes that are picked up by the accessibility engine.
  • String changes made/needed: None.
Flags: needinfo?(jteh)
Attachment #9172308 - Flags: approval-mozilla-beta?

Comment on attachment 9172308 [details]
Bug 1661382: Remove header and footer a11y semantics for print modal.

Approved for 81.0b5.

Attachment #9172308 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

This issue is verified fixed using Firefox 81.0b7 (BuildId:20200906164749) and Firefox 82.0a1 (BuildId:20200907094115) on Windows 10 64bit with NVDA screen reader.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.