1661382 - Remove print modal header and footer semantics for a11y

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P3)

Description

[James Teh [:Jamie]]

Semantics are normally a good thing. However, the print dialog is small enough that having the header and footer semantics doesn't really help the user with navigation and serves only to add extraneous verbosity for screen reader users.

STR (with the NVDA screen reader):

1. Open the print modal.
2. Tab to the print button.
   • Expected: NVDA should say "Print button"
   • Actual: NVDA says "content info landmark, Print button"

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1661382: Remove header and footer a11y semantics for print modal.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5712417ee27
Remove header and footer a11y semantics for print modal. r=mstriemer

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f5712417ee27

Comment 4

[Jonathan Watt [:jwatt]]

Do you want to request Beta uplift for this?

Comment 5

[James Teh [:Jamie]]

Comment on attachment 9172308 [details]
Bug 1661382: Remove header and footer a11y semantics for print modal.

Beta/Release Uplift Approval Request

• User impact if declined: Unnecessary screen reader verbosity in new print modal.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simply adds (well understood) attributes that are picked up by the accessibility engine.
• String changes made/needed: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172308 [details]
Bug 1661382: Remove header and footer a11y semantics for print modal.

Approved for 81.0b5.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a8ca363a76ba

Comment 8

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 81.0b7 (BuildId:20200906164749) and Firefox 82.0a1 (BuildId:20200907094115) on Windows 10 64bit with NVDA screen reader.