1661408 - Clean up wrench's command line handling

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Description

[Nicholas Nethercote [inactive]]

wrench's command line handling is a bit of a mess.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Bug 1661408 - Remove dead command line flags. r=gw

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Bug 1661408 - Fix confusion among the `show`, `load`, `replay` subcommands. r=gw

replay is currently listed in args.yaml as both a synonym for show and
its own command. There is some weirdness with how clap handles that:

• wrench help replay shows the help for replay.
• wrench replay -h shows the help for show.
• wrench replay actually runs the code for show (and there is no code for
  replay).

This commit removes the subcommand, leaving the synonym.

Depends on D88385

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Bug 1661408 - Update the README. r=gw

Remove references to dead things: binary recording, --save, ENABLE_RECORDING.

Add brief docs about building wrench, and taking a capture.

And show is the canonical name for the subcommand, not replay.

Depends on D88386

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: Bug 1661408 - Change meaning of `-h`. r=gw

Currently -h means --headless when it comes before a subcommand but
--help when it comes after a subcommand. It should always be short for
--help, that's a very standard thing.

Depends on D88387

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0114b020f0d9
Remove dead command line flags. r=gw
https://hg.mozilla.org/integration/autoland/rev/c63b95bef8c9
Fix confusion among the `show`, `load`, `replay` subcommands. r=gw
https://hg.mozilla.org/integration/autoland/rev/0eaa23944f7c
Update the README. r=gw
https://hg.mozilla.org/integration/autoland/rev/3e08cd7183a8
Change meaning of `-h`. r=gw

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0114b020f0d9
https://hg.mozilla.org/mozilla-central/rev/c63b95bef8c9
https://hg.mozilla.org/mozilla-central/rev/0eaa23944f7c
https://hg.mozilla.org/mozilla-central/rev/3e08cd7183a8