Open Bug 1661453 Opened 4 years ago Updated 4 years ago

[wpt-sync] Sync PR 25259 - [RTCInsertableStreams] Add validation for additionalData field in tests

Categories

(Core :: WebRTC, task, P4)

task

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25259 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25259
Details from upstream follow.

Guido Urdaneta <guidou@chromium.org> wrote:

[RTCInsertableStreams] Add validation for additionalData field in tests

This CL adds verification that the deprecated additionalData field
in video frames can be constructed based on the frame's metadata.

Bug: 1069295
Change-Id: I9b6c06a9e6126d4461cb1c15ce8981312def07c6
Reviewed-on: https://chromium-review.googlesource.com/2378310
WPT-Export-Revision: e2711f4200065ce3cb0cfb8b0d6b1b1dac777f89

Component: web-platform-tests → WebRTC
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 10 subtests

Status Summary

Firefox

OK : 2
PASS: 2
FAIL: 15

Chrome

OK : 2
PASS: 17

Safari

OK : 2
PASS: 2
FAIL: 15

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webrtc-insertable-streams/RTCPeerConnection-insertable-streams-audio.https.html
Frames flow correctly using insertable streams: FAIL (Chrome: PASS, Safari: FAIL)
Frames flow correctly using insertable streams when receiver starts negotiation: FAIL (Chrome: PASS, Safari: FAIL)
RTCRtpSender.createEncodedStream() throws if not requested in PC configuration: FAIL (Chrome: PASS, Safari: FAIL)
RTCRtpReceiver.createEncodedStream() throws if not requested in PC configuration: FAIL (Chrome: PASS, Safari: FAIL)
RTCRtpSender readable stream transferred to a Worker and the Worker sends an RTCEncodedAudioFrame back: FAIL (Chrome: PASS, Safari: FAIL)
Enqueuing the same frame twice fails: FAIL (Chrome: PASS, Safari: FAIL)
Legacy API works: FAIL (Chrome: PASS, Safari: FAIL)
/webrtc-insertable-streams/RTCPeerConnection-insertable-streams.https.html
Frames flow correctly using insertable streams: FAIL (Chrome: PASS, Safari: FAIL)
Frames flow correctly using insertable streams when receiver starts negotiation: FAIL (Chrome: PASS, Safari: FAIL)
RTCRtpSender.createEncodedStream() throws if not requested in PC configuration: FAIL (Chrome: PASS, Safari: FAIL)
RTCRtpReceiver.createEncodedStream() throws if not requested in PC configuration: FAIL (Chrome: PASS, Safari: FAIL)
RTCRtpSender readable stream transferred to a Worker and the Worker sends an RTCEncodedVideoFrame back: FAIL (Chrome: PASS, Safari: FAIL)
Key and Delta frames are sent and received: FAIL (Chrome: PASS, Safari: FAIL)
Enqueuing the same frame twice fails: FAIL (Chrome: PASS, Safari: FAIL)
Legacy API works: FAIL (Chrome: PASS, Safari: FAIL)

You need to log in before you can comment on or make changes to this bug.