1661517 - Remove extensions.allowPrivateBrowsingByDefault preference

Status: VERIFIED FIXED

(WebExtensions :: General, task, P3)

Comment 2

[charlesanita403]

is this issue still open? if yes, can I attempt it, please?
[e-mail]

Comment 3

[Rob Wu [:robwu]]

Thanks for your interest in this bug. I've clarified the title, Shane will follow up with a comment.

Comment 4

[Shane Caraveo (:mixedpuppy)]

I apologize for missing the question. Are you still interested in taking this?

Comment 5

[Shane Caraveo (:mixedpuppy)]

No response, clearing need info's.

Comment 6

[Sonia Singla :soniasingla]

Attachment: Bug 1661517 - Removed extensions.allowPrivateBrowsingByDefault preference. r=mixedpuppy

Comment 7

[dkousvgi]

extensions.allowPrivateBrowsingByDefault is true by default in Tor Browser, differing from Firefox.

Issue in Tor Browser's GitLab

Comment 8

[Rob Wu [:robwu]]

The Tor Browser uses permanent private browsing mode by default (via pref("browser.privatebrowsing.autostart", true);). We could look into automatically enabling extensions in permanent private browsing mode (bug 1585431). That work does not need to block this bug, since Tor builds on ESR anyway.

Comment 9

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=035931dd9db41914fae4e257245dcc5430d0c6bf

Comment 10

[Caitlin Neiman [:caitmuenster]]

Hey Sonia, just wanted to check in. :) Are you still working on this bug?

Comment 11

[Caitlin Neiman [:caitmuenster]]

Hey Sonia, just another friendly check in on this issue. :) How's it going?

Comment 12

[Sonia Singla :soniasingla]

Updating it now, thanks for checking :)

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2dbafe38826
Removed extensions.allowPrivateBrowsingByDefault preference. r=mixedpuppy

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f2dbafe38826

Comment 16

[Alex Cornestean]

Hello,

Verified the fix on the latest Nightly (91.0a1/20210603094827) under Windows x64 and Ubuntu 16.04 LTS.

Compared the existence of the pref in about:config between Nightly and Release. On Release the pref still exists and is set to false, while on Nightly it is no longer available, confirming the fix. For further details, please see the attached screenshot.

Comment 17

[Alex Cornestean]

Attachment: 2021-06-04_12h44_46.png

Comment 18

[Boris Prpic]

Hi,

by removing this preference there is no more way to programmatically turn on this setting in testing environment with WebDriver.

I have web extension that talks with my app over WebDriver and controls proxy in browser. It is broken currently as extension cant call browser.proxy.settings.set api without private browsing permission and I have no way to set that permission from geckodriver.

Comment 19

[Rob Wu [:robwu]]

(In reply to Boris Prpic from comment #18)

Hi,

by removing this preference there is no more way to programmatically turn on this setting in testing environment with WebDriver.

I have web extension that talks with my app over WebDriver and controls proxy in browser. It is broken currently as extension cant call browser.proxy.settings.set api without private browsing permission and I have no way to set that permission from geckodriver.

Could you file a new bug for this issue? Please include relevant information, such as a set of (minimal) steps to reproduce the issue.

Comment 20

[Boris Prpic]

(In reply to Rob Wu [:robwu] from comment #19)

(In reply to Boris Prpic from comment #18)

Hi,

by removing this preference there is no more way to programmatically turn on this setting in testing environment with WebDriver.

I have web extension that talks with my app over WebDriver and controls proxy in browser. It is broken currently as extension cant call browser.proxy.settings.set api without private browsing permission and I have no way to set that permission from geckodriver.

Could you file a new bug for this issue? Please include relevant information, such as a set of (minimal) steps to reproduce the issue.

OK. Here: https://bugzilla.mozilla.org/show_bug.cgi?id=1729315