Ensure we always update the failure reason for gfx features
Categories
(Core :: Graphics, task, P1)
Tracking
()
People
(Reporter: aosmond, Assigned: aosmond)
References
Details
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Right now we only update the gfx feature failure reason if there is no current reason. This makes it very hard to know why something happened. We have exploited this to figure out if there are multiple root causes for failure, but we should probably just add a failure counter for that in another bug.
|
Assignee | |
Comment 1•4 years ago
|
||
I would really like this in early beta 81 now that I am inspecting failures more closely...
|
|
Assignee | |
Comment 2•4 years ago
|
||
Specifically we see an uptick in "unavailable" on early beta for the WebRender (not WebRender qualified) feature, which suggests we lost WebRender for some reason. However the failure reason is kept as "FEATURE_FAILURE_DEFAULT_OFF" which is the default reason (so it is always present and never overridden).
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
|
Assignee | |
Comment 4•4 years ago
|
||
Comment on attachment 9172457 [details]
Bug 1661531 - Ensure we always update the gfx feature failure reason.
Beta/Release Uplift Approval Request
- User impact if declined: We won't be able to adequately diagnosed why some users don't get WebRender in early beta.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial change, goes from assign once, to always assign, and only impacts reporting. No user facing change.
- String changes made/needed:
Pushed by aosmond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/346a825d1ce6 Ensure we always update the gfx feature failure reason. r=kats
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
|
||
Comment 7•4 years ago
|
||
Comment on attachment 9172457 [details]
Bug 1661531 - Ensure we always update the gfx feature failure reason.
Approved for 81.0b4.
|
|
||
Comment 8•4 years ago
|
||
| bugherder uplift | ||
Description
•