1661543 - Thread contention between nsNSSComponent's background task queue and NSS

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[J.C. Jones [:jcj] (he/they)]

Profiling by :acreskey has shown the race fix in Bug 1651449 has caused a performance regression on desktop and mobile, with many profiles to support it.

Regression window is specifically this commit: https://hg.mozilla.org/mozilla-central/rev/323e4aecc563981f5090ef9a01888888987f75f5

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

I think the safest approach would be to backout:

• https://hg.mozilla.org/mozilla-central/rev/323e4aecc563981f5090ef9a01888888987f75f5 for 81 and 82
• https://hg.mozilla.org/releases/mozilla-beta/rev/78c4aeb1bca3 for 80
• https://hg.mozilla.org/releases/mozilla-esr78/rev/a28c58add438 for ESR78

Comment 2

[Andrew Creskey [:acreskey]]

Stefan, will this ensure that the Android Components build that Fenix uses will include the backout?

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

To get these fixes in Fenix, we will need new GeckoView 80 and 81 Beta releases.

Comment 4

[Julien Cristau [:jcristau]]

Backed out bug 1651449 from beta for 81.0b3:
https://hg.mozilla.org/releases/mozilla-beta/rev/25ae363f586ea237fa86be992f385dadf706cbd9

Comment 5

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/9314b9de4647

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8fcc41684a9f
Backed out 1 changesets (bug 1651449) for performance regression. a=backout CLOSED TREE

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8fcc41684a9f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backout landed on ESR78 for the regularly-scheduled 78.3esr release:
https://hg.mozilla.org/releases/mozilla-esr78/rev/2fd428c0b23b