1661552 - Sorting about:processes by Name sorts only the subitems

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P3)

Description

[Itiel]

STR:

1. Open about:processes
2. Click the Name column header once -- the separators are gone (not sure if intentionaly or not), and the top-level item names are not actually sorted
3. Expand any top-level item and sort by name -- the subitems are being sorted, and not the top-level ones

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Oh, right. That's going to be a bit tricky to solve.

Names used to be computed in aboutProcesses.js but they're now outsourced to Fluent.

So I see the following options:

1. Compute the names twice, once for sorting and once for display.
2. Adopt an approximation in which we actually sort by origin rather than by alphanumerical order.
3. Call Fluent much earlier to determine names way before we need to display them (or before we even know whether we'll need to display them).

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1661552 - In about:processes, sorting by name now sorts by origin;r?florian

Sorting by name used to work because we computed the display name of each process within aboutProcesses.js. These days, fluent does the job, so this doesn't work anymore.

This patch approximates sorting by name with sorting by origin.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac4c876a2e1d
In about:processes, sorting by name now sorts by origin;r=florian

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ac4c876a2e1d