1661569 - The web console is broken when browser console or browser toolbox is opened

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Alexandre Poirot [:ochameau]]

Copied from bug 1642295 comment 12:

Trying to make this clear steps to test for what I'm hitting and how I test it:

1. Using current master, and open it with the multi process debugger open, I do this via ./mach run --jsdebugger -P the --jsdebugger part is the important part, but I suspect there are other ways to open it, what's important though is the multi process debugger is open when you start the browser.
2. I created a new profile for testing this, but I suspect it doesn't matter.
3. Once I'm in the browser, I open an about:home tab, but I suspect the page doesn't matter.
4. From here I do ctrl+shift+k to open the browser console.
5. Inside the console, I enter console.log("hi"); and hit enter.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1661569 - Avoid mixing target actor of the many toolboxes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67fe975e6653
Avoid mixing target actor of the many toolboxes. r=nchevobbe

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/67fe975e6653

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9172513 [details]
Bug 1661569 - Avoid mixing target actor of the many toolboxes.

Beta/Release Uplift Approval Request

• User impact if declined: DevTools console won't display messages when Responsive Design Mode is enabled first
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open a tab

1. Enable Responsive Design Mode
2. Open DevTools Console
3. Type console.log(document)

-> check that the document is displayed

• List of other uplifts needed: Bug 1664493
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): DevTools only, with a test added in Bug 1664493 (late in the cycle because the RDM bug wasn't found here)
• String changes made/needed:

Comment 5

[Ciprian Georgiu, Desktop QA]

I was able to reproduce the bug using the steps from comment 4, on 81.0 RC2.

The fix is verified as fixed on latest Beta 82.0b2, under macOS 10.15, Win 10 x64 and Ubuntu 18.04 x64/

Comment 6

[Ryan VanderMeulen [:RyanVM]]

If I'm reading the blame correctly, this is a regression which goes back to Fx80? What's driving the urgency to uplift this into a dot release vs. waiting for the scheduled Fx82 release in a few weeks?

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Oh, I didn't notices 80 was impacted.
I'm okay to wait for 82