166159 - ctl/hindiShaper/dvng-x.c issue

Status: RESOLVED WONTFIX

(Core :: Layout: Text and Fonts, defect)

Description

[Masaki Katakai]

One issue is that dvng-x.c. While I tried to
fix whitespace issue of bug 163962,
I found the problem that

{ does not match in the first case.

static gint
get_adjusted_glyphs_list(DvngFontInfo *fontInfo,

  case St17:
    if (IsDvngCharCls(cluster[nChars - 1], _UP)) { <====

's { matches with

  case St20:
    if (IsDvngCharCls(cluster[0], _MS))
      gLst[nGlyphs++] = PANGO_MOZ_MAKE_GLYPH(0xF816);
    else
      gLst[nGlyphs++] = PANGO_MOZ_MAKE_GLYPH(0xF81A);

    GetBaseConsGlyphs(cluster+2, nChars - 4, &gLst[nGlyphs], &nGlyphs);
    break;
    } <===============================================


Prabhat, what do you think? Could you correct the codes? also
includ whitespace issue?

The build is OK, no problem but we have to correct this.

Comment 1

[Roland Mainz]

Can we kill the TABs in the sources with this bug, please (I already did that
for the new code but the thai part is still full of TABs) ?

Comment 2

[Rui Xu]

code issue? QA to [e-mail] for now.

Comment 3

[Prabhat Hegde]

I don't see this problem with what's in the trunk.

Comment 4

[Roland Mainz]

prabhat:
Is this bug fixed now ?

Comment 5

[Simon Montagu :smontagu]

Source file no longer exists.