[wpt-sync] Sync PR 25266 - Transferable Streams: Fix crash on deserialization error
Categories
(Core :: DOM: Streams, task, P4)
Tracking
()
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 25266 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/25266
Details from upstream follow.
Adam Rice <ricea@chromium.org> wrote:
Transferable Streams: Fix crash on deserialization error
The transferable streams implementation would crash when it received a
chunk that wasn't deserializable, because it failed to enter a
ScriptScope before creating a V8 object.Fix it.
Also fix the message on the DOMException that is created when
deserialization fails.Add a test for deserialization failure. This is hard to trigger in a
cross-browser fashion. In this test, we use a WASM module, which can't
be transferred to a different site.BUG=1122725
Change-Id: I6e49c69978388357a3c6006cc02dce8f0a949954
Reviewed-on: https://chromium-review.googlesource.com/2379417
WPT-Export-Revision: 6c808f0fd291591766ab46953ed97902c9372ff7
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI
Total 1 tests and 2 subtests
Status Summary
Firefox
TIMEOUT: 2
ERROR : 1
Chrome
CRASH : 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/streams/transferable/deserialize-error.window.html: ERROR (Chrome: CRASH)
a WritableStream deserialization failure should result in a DataCloneError: TIMEOUT
a ReadableStream deserialization failure should result in a DataCloneError: TIMEOUT
|
||
Updated•5 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 4•3 years ago
|
||
Merged by bug 1664225.
Description
•