1661608 - Assertion failure: aViewportType != ViewportType::Visual, at layout/generic/nsIFrame.cpp:6765

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

STR;

1. Open https://www.w3schools.com/html/html_iframe.asp
2. Open the print preview window
3. Click somewhere inside the iframe in the print preview

I am a bit worried that it's a result of bug 1660490. I wanted to do mozregression but mozregression doesn't work for debug builds now (bug 1661607).

Comment 1

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #0)

I am a bit worried that it's a result of bug 1660490.

No, it's not! I did revert the change locally, but still I can get the assertion. (I need mozregresion..)

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://searchfox.org/mozilla-central/rev/ce21a13035623c1d349980057d09000e70669802/layout/generic/nsIFrame.cpp#6765 is the line crashing. Do you happen to have a crash stack?

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: A call stack

I hadn't yet. :)

Comment 4

[Botond Ballo [:botond] [away until Oct 19]]

Sorry, I may have misunderstood. I marked bug 1556556 as the regressing change because it is what introduced the assertion, but it sounds like this broke recently as a result of another change?

Comment 5

[Botond Ballo [:botond] [away until Oct 19]]

Mozregression points to the actual regressing bug being bug 1640381.

Comment 6

[Botond Ballo [:botond] [away until Oct 19]]

Attachment: Bug 1661608 - Use correct viewport type in RecordMouseLocation(). r=tnikkel

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11a7c8990f93
Use correct viewport type in RecordMouseLocation(). r=tnikkel

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/11a7c8990f93

Comment 9

[Jonathan Watt [:jwatt]]

Do we care to uplift this to Beta? It seems the regressing bug landed for v78 so I guess not, but asking just in case.

Comment 10

[Botond Ballo [:botond] [away until Oct 19]]

It's a debug-only assertion and I'm not expecting hitting this codepath to cause any trouble in terms of functionality, so let's not uplift.