1661629 - Print preview dialog shouldn't be sized based on RDM

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

If you open the print preview dialog in RDM, the dialog appears inside the RDM window, it's pretty awkward.

Comment 1

[:Gijs (out for now; he/him)]

Attachment: Bug 1661629 - size tabdialogbox items correctly when shown in responsive design mode, r?mtigley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/008d2bdf5bd5
size tabdialogbox items correctly when shown in responsive design mode, r=mtigley

Comment 3

[:Gijs (out for now; he/him)]

Comment on attachment 9173798 [details]
Bug 1661629 - size tabdialogbox items correctly when shown in responsive design mode, r?mtigley

Beta/Release Uplift Approval Request

• User impact if declined: modal dialog boxes look crummy in responsive design mode
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 4 lines of CSS that only gets used for dialogs when in responsive design mode. Should be fine.
• String changes made/needed: n/a

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/008d2bdf5bd5

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173798 [details]
Bug 1661629 - size tabdialogbox items correctly when shown in responsive design mode, r?mtigley

Approved for 81.0b7.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/467dcfb2169b

Comment 7

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed on macOS 10.15, Ubuntu 18.04 and Windows 10x64. Verified using 82.0a1 (2020-09-09) and 81.0b8.