1661646 - Add extra keys to YSOD Telemetry

Status: RESOLVED FIXED

(Core :: XML, task)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

In bug 1657242 we added basic YSOD telemetry and the numbers are high enough that we want to understand more of what errors are we seeing.

I'm going to add two extra keys:

• error_code based on https://searchfox.org/mozilla-central/rev/ce21a13035623c1d349980057d09000e70669802/parser/expat/lib/expat.h#55
• location as line:col

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1661646 - Extend YSOD Telemetry with error_code and location. r?peterv

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: data-review-ysod.txt

Comment 3

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9172591 [details]
data-review-ysod.txt

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in the probe definition files and the Probe Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, zbraniecki.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Cat 1, technical data.

5. Is the data collection request for default-on or default-off?

Default-on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does there need to be a check-in in the future to determine whether to renew the data?

No.

9. Does the data collection use a third-party collection tool?

No.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fce6294438c
Extend YSOD Telemetry with error_code and location. r=froydnj

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9fce6294438c

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 9172590 [details]
Bug 1661646 - Extend YSOD Telemetry with error_code and location. r?peterv

Beta/Release Uplift Approval Request

• User impact if declined: We'll take another 3 weeks to learn about the error codes YSOD events happen for.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This just adds two keys to an YSOD Telemetry event for chrome urls.
• String changes made/needed: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172590 [details]
Bug 1661646 - Extend YSOD Telemetry with error_code and location. r?peterv

Approved for 81.0b5.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3b42ae20954d