Open Bug 1661688 Opened 1 year ago Updated 3 months ago

Crash in [@ objc_msgSend | +[NSString stringWithString:]] (from system dialog)

Categories

(Core :: Widget: Cocoa, defect, P3)

All
macOS
defect

Tracking

()

Tracking Status
firefox81 --- affected
firefox83 --- affected
firefox84 --- affected

People

(Reporter: emilghitta, Unassigned)

Details

(Keywords: crash, Whiteboard: [print2020][old-ui+])

Crash Data

Crash report: https://crash-stats.mozilla.org/report/index/a8ea1dfb-2d7c-41c6-9fa9-d69160200828

Top 10 frames of crashing thread:

0 libobjc.A.dylib objc_msgSend 
1 Foundation +[NSString stringWithString:] 
2 KfSummary KfSummary@0xd303 
3 KfSummary KfSummary@0xcb25 
4 PrintCocoaUI PrintCocoaUI@0x26f2 
5 PrintCocoaUI PrintCocoaUI@0x8be7 
6 PrintCocoaUI CreateDefaultFileName 
7 PrintCocoaUI CreateDefaultFileName 
8 AppKit AppKit@0x30c87f 
9 AppKit AppKit@0x368aa6 

Encountered this crash on 81.0b3 macOS 10.14 while selecting the "Open in Preview" (from the PDF dropdown menu) option from the old print system modal.

I can see that this is not 100% reproducible. I'm going to investigate this in order to find some reliable STR.

Component: Printing → Printing: Output
Product: Toolkit → Core
Whiteboard: [old-ui+] → [print2020_v81][old-ui+]
Severity: -- → S2
Priority: -- → P1

Once bug 1653340 lands, this codepath (PrintingParent::ShowPrintDialog) will no longer be exercised.

Priority: P1 → P2
Has STR: --- → no

(In reply to Jonathan Watt [:jwatt] from comment #1)

Once bug 1653340 lands, this codepath (PrintingParent::ShowPrintDialog) will no longer be exercised.

I missed that this bug was about the old UI specifically. This codepath is still exercised by the old UI.

With regards to priority, there don't appear to be new crash reports against Beta yet since the 5 crashes on the 28 August (all you presumably, Emil, since that was the day you reported this). It's a bit early to say since the pref only just turned off in 81b7, but hopefully this isn't a big issue.

I'll keep this on the v82 list for now, but drop to P3 given no further crashes have been reported.

Priority: P2 → P3
Whiteboard: [print2020_v81][old-ui+] → [print2020_v82][old-ui+]
Whiteboard: [print2020_v82][old-ui+] → [print2020_v83][old-ui+]
Whiteboard: [print2020_v83][old-ui+] → [print2020_v84][old-ui+]

Encountered this crash recently on my macOS 10.14 -> https://crash-stats.mozilla.org/report/index/c0f9d607-6a4a-4e98-9c7d-c35e40201103.

Updating the flags.

Whiteboard: [print2020_v84][old-ui+] → [print2020_v85][old-ui+]
Whiteboard: [print2020_v85][old-ui+] → [print2020_v88][old-ui+]
Whiteboard: [print2020_v88][old-ui+] → [print2020][old-ui+]
QA Whiteboard: qa-not-actionable

For what it's worth, a recent crash report with this signature also has interesting mac_crash_info:

bp-13014415-d128-4621-a0b6-ad9b60210713

    {
      "num_records": 1,
      "records": [
        {
          "message": "Performing @selector(doPrint:) from sender NSButton 0x13862f450",
          "module": "/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit"
        }
      ]
    }

So it's likely that these crashes, when they happen, are triggered by clicking on the Print button in the (old) print dialog.

Summary: Crash in [@ objc_msgSend | +[NSString stringWithString:]] → Crash in [@ objc_msgSend | +[NSString stringWithString:]] (from system dialog)

Steven, this seems like a macOS system print dialog bug, or at least doPrint doesn't seem our code, do you know where to file it?

Flags: needinfo?(spohl.mozilla.bugs)

Moving this to widget:cocoa. The next step would be to file this with Apple, but since the crash volume is low and that the crash appears to occur in our old print dialog, there doesn't seem to be anything immediately actionable here.

Component: Printing: Output → Widget: Cocoa
Flags: needinfo?(spohl.mozilla.bugs)

Fwiw it doesn't happen just with the old print dialog. As in, the system print dialog is still accessible from the new UI.

You need to log in before you can comment on or make changes to this bug.