1661695 - Use --fast-warmup for shell tests

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

In bug 1660592 Iain added the --fast-warmup flag. We should use this for shell tests so we can more easily change our warm-up thresholds without affecting tests.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1661695 part 1 - Disable optimization levels if Warp is enabled. r?iain!

We don't currently use this in Warp and it can cause some weirdness, especially
with lower warmup thresholds and off-thread compilation, where we start a
recompile for no good reason.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/432bd3686fd3
part 1 - Disable optimization levels if Warp is enabled. r=iain

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/432bd3686fd3

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jandem, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Comment 8

[Nicolas B. Pierron [:nbp]]

Given that wrap has landed a while back, I do not see any reasons to land this patch anymore.
Also, we now have --ion-warmup-threshold=100 command line option to answer comment 0.