1661715 - GTK symbol stubs in the wrong section

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Olivier Tilloy]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.83 Safari/537.36

Steps to reproduce:

Downstream (Ubuntu) bug report: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1893021

With the release of firefox 80.0, loading the flash plugin on Ubuntu 16.04 was failing with the following error:

/usr/lib/firefox/plugin-container: symbol lookup error: /usr/lib/firefox/libxul.so: undefined symbol: gtk_window_set_titlebar

Actual results:

In previous releases, loading the flash plugin worked fine.

Expected results:

This regression was caused by two recent revisions: https://phabricator.services.mozilla.com/D84623 and https://phabricator.services.mozilla.com/D82804, which added GTK function stubs (in widget/gtk/mozgtk/mozgtk.c in the wrong section (they were added to the COMMON_SYMBOLS section but they should be in the GTK3_SYMBOLS because they are GTK3 only).

Comment 1

[Olivier Tilloy]

Attachment: Bug 1661715 - Move GTK function stubs to the correct section.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d87a8dae5fe
Move GTK function stubs to the correct section. r=karlt

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5d87a8dae5fe

Comment 5

[Robert Mader [:rmader]]

Ouch, sorry and thanks for that!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 7

[Olivier Tilloy]

Sure. I'm not sure how to nominate a bug/revision for beta approval, though?

Comment 8

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/mozilla-central/rev/45e8dd195f71 actually landed in 80.

Comment 9

[Karl Tomlinson (:karlt)]

Comment on attachment 9172666 [details]
Bug 1661715 - Move GTK function stubs to the correct section.

Beta/Release Uplift Approval Request

• User impact if declined: Flash plugin fails to load.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change affects only plugins.
• String changes made/needed: None.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172666 [details]
Bug 1661715 - Move GTK function stubs to the correct section.

Approved for 81.0b5.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/02a9269355fc

Comment 12

[Florencia Di Ciocco, NI to vbalducci]

Attachment: 'GTK_IS_STYLE_CONTEXT (context)' failed

Hi, 

On Ubuntu 16.04 LTS I downloaded FF Nightly 82.0a1 (2020-08-28) (64-bit), opened it from a terminal with the command ./firefox -p and I did not see the error message. But when I closed the browser and ran the same command again, hence restarting and updating nightly to 82.0a1 (2020-09-04) (64-bit), I saw the attached error messages.
How should we proceed?

Comment 13

[Florencia Di Ciocco, NI to vbalducci]

Repeated comment, please ignore it

Comment 14

[Martin Stránský [:stransky] (ni? me)]

I think you can safely ignore that, that comes from Gtk3 library which complains about error in actual Gtk theme. Eventually you can change your Gtk theme in gnome-tweaks application.

Comment 15

[Florencia Di Ciocco, NI to vbalducci]

Ok, thanks for the answer. So I proceed to change the bug from resolved to verify.

Regards, Flor.