1661791 - Remove "New Non-Fission Window" menu item and "[F]" tab tooltip suffix

Status: RESOLVED FIXED

(Firefox :: Menus, task, P5)

Description

[Chris Peterson [:cpeterson]]

After we ship Fission to everyone, we can remove mentions of Fission from the Firefox UI, such as the "Open Non-Fission Window" menu item and "[F]" tab tooltip suffix.

We should also remove the Fission experiment pref added in bug 1660057.

Comment 1

[Chris Peterson [:cpeterson]]

Nika, this bug proposes to remove the "New Non-Fission Window" menu item. Besides removing the UI, do we also want to remove support for creating non-Fission windows programmatically? That was added in bug 1542791 and is used by some tests.

Some tests that force Fission or non-Fission windows:

• https://searchfox.org/mozilla-central/rev/1674b86019a96f076e0f98f1d0f5f3ab9d4e9020/browser/base/content/test/general/browser_tab_drag_drop_perwindow.js#185-197
• https://searchfox.org/mozilla-central/rev/1674b86019a96f076e0f98f1d0f5f3ab9d4e9020/devtools/client/framework/test/browser_toolbox_hosts.js#34-41
• https://searchfox.org/mozilla-central/rev/1674b86019a96f076e0f98f1d0f5f3ab9d4e9020/devtools/client/shared/test/browser_layoutHelpers_getBoxQuads2.js#7-10,57-61

Comment 2

[Chris Peterson [:cpeterson]]

Also, do we still need the WINDOW_REMOTE_SUBFRAMES_ENABLED_STATUS telemetry probe if Fission is the default?

Comment 3

[Nika Layzell [:nika] (ni? for response)]

(In reply to Chris Peterson [:cpeterson] from comment #1)

Nika, this bug proposes to remove the "New Non-Fission Window" menu item. Besides removing the UI, do we also want to remove support for creating non-Fission windows programmatically? That was added in bug 1542791 and is used by some tests.

I think we may want to remove support for it eventually, but I don't think we need to rush to do it right away because it'd be inconvenient for some tests. We should eventually switch it up though, probably.

When we remove the [F] marker, let's make sure to still log out the subframe pids in some way in the tab tooltip, perhaps by logging every pid in the (pid XXX) section just making sure that the toplevel pid comes first.

(In reply to Chris Peterson [:cpeterson] from comment #2)

Also, do we still need the WINDOW_REMOTE_SUBFRAMES_ENABLED_STATUS telemetry probe if Fission is the default?

Yeah, we can probably get rid of it once we've rolled out.

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: Bug 1661791 - Remove "New Non-Fission Window" menu item. r?mconley

Now that Fission is the default, we don't want people to open Fission and non-Fission windows in the same session.

Comment 5

[Chris Peterson [:cpeterson]]

Attachment: Bug 1661791 - Remove Fission [F] tab toolip and move subframe pids to the (pid) tooltip. r?mconley

Instead of showing:

(pid 3) [F 2, 1, 4]

The tab tooltip will now show a combined list of pids with the content pid followed by a sorted list of subframe pids:

(pids 3, 1, 2, 4)

Depends on D133854

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/617d642dedfa
Remove "New Non-Fission Window" menu item. r=mconley
https://hg.mozilla.org/integration/autoland/rev/67c3b3e70953
Remove Fission [F] tab toolip and move subframe pids to the (pid) tooltip. r=mconley

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/617d642dedfa
https://hg.mozilla.org/mozilla-central/rev/67c3b3e70953