1661810 - Crash @ arm_aes_encrypt_ecb_128 when building with clang 11

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Mike Hommey [:glandium]]

https://crash-stats.mozilla.org/report/index/ffcd0667-12af-4ade-8915-486220200828

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1661810 - Define pre_align/post_align based on the compiler.

Things worked fine before we upgraded to clang 11 presumably because the
stack was always 16-bytes aligned in the first place, or something akin
to that, and the lack of pre_align/post_align doing anything didn't
matter. The runtime misalignment of the stack may well be a clang > 9
bug, but keeping pre_align/post_align tied to the x86/x64 is a footgun
anyways.

Comment 3

[Mike Hommey [:glandium]]

We'll need an NSS update in mozilla-central to pick this and unblock bug 1660340. How do we go about that? (Or can we just cherry-pick? Surely the next update should not lose the change, since it's now landed)

Comment 4

[J.C. Jones [:jcj] (he/him)]

Just landed it on autoland, :glandium: https://hg.mozilla.org/integration/autoland/rev/f39bc2f76fe1

Comment 5

[Mike Hommey [:glandium]]

Thank you.

Comment 6

[J.C. Jones [:jcj] (he/him)]

https://hg.mozilla.org/projects/nss/rev/c100e11991f68f60d53b2ebe1975c39ddf8bf784

Comment 7

[Ryan VanderMeulen [:RyanVM]]

I assume we're not worried about downstream distros trying to build <82 with clang11, but feel free to correct me if I'm wrong.