Closed Bug 1661812 Opened 4 years ago Closed 4 years ago

Consider to use longer timeout for slow script warning if there isn't any important user input pending

Categories

(Core :: XPConnect, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

If user isn't clicking or typing on the page, slow script warning could possibly show up later.

Severity: -- → N/A
Priority: -- → P5

The patch converts the relevant prefs to use StaticPrefList and let's content JS in child processes to run longer if there
aren't mousedown/ups or keyevents or such. mousemove or wheel aren't considered as important events.

esmyth, curious, has there been some more investigation what kind of behavior we want?
I just wrote the patch to catch the case when I see the slow script warning when I think I shouldn't
(occasionally loading https://www.worldometers.info/coronavirus/coronavirus-cases/ and clicking 'cases by country and territory' leads to the warning).

Flags: needinfo?(esmyth)

:smaug, from a personal preference, I like a lot about this approach. I believe that we'll want to adjust the behavior, but I haven't investigated beyond what is already in the long-running script PRD. gijs added some telemetry in Fx80 that should help us better understand reach and impact of long-running scripts in Release (mconley is also tackling from another angle via his bhr annotation proposal). We're planning to perform initial analysis of the new telemetry in mid to late September to help guide next steps and possibly strengthen a request for UX and/or UR support for UI changes.

Flags: needinfo?(esmyth)
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d21c69ba63a2
Consider to use longer timeout for slow script warning if there isn't any important user input pending r=mccr8,geckoview-reviewers,snorp
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Regressions: 1662574
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: