Open Bug 1661832 Opened 4 years ago Updated 4 years ago

[wpt-sync] Sync PR 25279 - [css-pseudo] Don't inherit text-indent to ::marker

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25279 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25279
Details from upstream follow.

b'Oriol Brufau <obrufau@igalia.com>' wrote:

[css-pseudo] Don't inherit text-indent to ::marker

The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568
that properties like 'text-indent' that don't apply to ::marker, should
not be able to affect the ::marker via inheritance when set to an
ancestor.

Therefore, this patch sets 'text-indent: 0 !important' in UA origin.

Bug: 1031667

TEST=external/wpt/css/css-pseudo/marker-content-023.html
TEST=external/wpt/css/css-pseudo/marker-default-styles.html
TEST=http/tests/devtools/elements/styles-2/pseudo-elements.js

Change-Id: I4dd9e8afd448bd5fe237c084d3c0215e91560dd1

Reviewed-on: https://chromium-review.googlesource.com/2382750
WPT-Export-Revision: 10be4e0cf8901426b34401ad4571ba5083c2061c

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 32 subtests

Status Summary

Firefox

OK : 1
PASS: 16
FAIL: 17

Chrome

OK : 1
PASS: 24
FAIL: 9

Safari

OK : 1
PASS: 3
FAIL: 30

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-pseudo/marker-content-023.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-pseudo/marker-default-styles.html
Computed value of 'text-transform' for outside symbol: FAIL (Chrome: PASS, Safari: FAIL)
Computed value of 'text-indent' for outside symbol: FAIL (Chrome: FAIL, Safari: FAIL)
Computed value of 'text-transform' for outside decimal: FAIL (Chrome: PASS, Safari: FAIL)
Computed value of 'text-indent' for outside decimal: FAIL (Chrome: FAIL, Safari: FAIL)
Computed value of 'text-transform' for outside string: FAIL (Chrome: PASS, Safari: FAIL)
Computed value of 'text-indent' for outside string: FAIL (Chrome: FAIL, Safari: FAIL)
Computed value of 'text-transform' for outside marker: FAIL (Chrome: PASS, Safari: FAIL)
Computed value of 'text-indent' for outside marker: FAIL (Chrome: FAIL, Safari: FAIL)
Computed value of 'text-transform' for inside symbol: FAIL (Chrome: PASS, Safari: FAIL)
Computed value of 'text-indent' for inside symbol: FAIL (Chrome: FAIL, Safari: FAIL)
Computed value of 'text-transform' for inside decimal: FAIL (Chrome: PASS, Safari: FAIL)
Computed value of 'text-indent' for inside decimal: FAIL (Chrome: FAIL, Safari: FAIL)
Computed value of 'text-transform' for inside string: FAIL (Chrome: PASS, Safari: FAIL)
Computed value of 'text-indent' for inside string: FAIL (Chrome: FAIL, Safari: FAIL)
Computed value of 'text-transform' for inside marker: FAIL (Chrome: PASS, Safari: FAIL)
Computed value of 'text-indent' for inside marker: FAIL (Chrome: FAIL, Safari: FAIL)

You need to log in before you can comment on or make changes to this bug.