1661833 - Perma [fission][tier2] browser/base/content/test/general/browser_alltabslistener.js | Got a notification for the front notifications listener - Got "onStateChange", expected "onLocationChange"

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=314320248&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/G0tYNBH1Q8mjeDWitR6ygg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-08-28T21:09:01.074Z] 21:09:01 INFO - TEST-PASS | browser/base/content/test/general/browser_alltabslistener.js | Got an expected notification for the front notifications listener - 2 < 5 -
[task 2020-08-28T21:09:01.074Z] 21:09:01 INFO - Buffered messages finished
[task 2020-08-28T21:09:01.075Z] 21:09:01 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_alltabslistener.js | Got a notification for the front notifications listener - Got "onStateChange", expected "onLocationChange"
[task 2020-08-28T21:09:01.075Z] 21:09:01 INFO - Stack trace:
[task 2020-08-28T21:09:01.075Z] 21:09:01 INFO - chrome://mochikit/content/browser-test.js:test_is:1332
[task 2020-08-28T21:09:01.075Z] 21:09:01 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_alltabslistener.js:onStateChange:33
[task 2020-08-28T21:09:01.075Z] 21:09:01 INFO - chrome://browser/content/tabbrowser.js:callListeners:832
[task 2020-08-28T21:09:01.076Z] 21:09:01 INFO - chrome://browser/content/tabbrowser.js:_callProgressListeners:846
[task 2020-08-28T21:09:01.076Z] 21:09:01 INFO - chrome://browser/content/tabbrowser.js:_callProgressListeners:5826
[task 2020-08-28T21:09:01.076Z] 21:09:01 INFO - chrome://browser/content/tabbrowser.js:onStateChange:6091
[task 2020-08-28T21:09:01.076Z] 21:09:01 INFO - AllProgress (http://example.org/browser/browser/base/content/test/general/alltabslistener.html): onStateChange 0xf0001
[task 2020-08-28T21:09:01.080Z] 21:09:01 INFO - TEST-PASS | browser/base/content/test/general/browser_alltabslistener.js | onStateChange notification came from the correct browser -
[task 2020-08-28T21:09:01.080Z] 21:09:01 INFO - TEST-PASS | browser/base/content/test/general/browser_alltabslistener.js | Got an expected notification for the all notifications listener - 1 < 4 -
[task 2020-08-28T21:09:01.080Z] 21:09:01 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-08-28T21:09:01.080Z] 21:09:01 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/general/browser_alltabslistener.js | Got a notification for the all notifications listener - Got "onStateChange", expected "onLocationChange"
[task 2020-08-28T21:09:01.080Z] 21:09:01 INFO - Stack trace:
[task 2020-08-28T21:09:01.081Z] 21:09:01 INFO - chrome://mochikit/content/browser-test.js:test_is:1332
[task 2020-08-28T21:09:01.081Z] 21:09:01 INFO - chrome://mochitests/content/browser/browser/base/content/test/general/browser_alltabslistener.js:onStateChange:102
[task 2020-08-28T21:09:01.081Z] 21:09:01 INFO - chrome://browser/content/tabbrowser.js:callListeners:832
[task 2020-08-28T21:09:01.081Z] 21:09:01 INFO - chrome://browser/content/tabbrowser.js:_callProgressListeners:852
[task 2020-08-28T21:09:01.081Z] 21:09:01 INFO - chrome://browser/content/tabbrowser.js:_callProgressListeners:5826
[task 2020-08-28T21:09:01.081Z] 21:09:01 INFO - chrome://browser/content/tabbrowser.js:onStateChange:6099
[task 2020-08-28T21:09:01.081Z] 21:09:01 INFO - GECKO(3767) | [Child 4182, Main Thread] WARNING: NS_ENSURE_TRUE(info) failed: file /builds/worker/checkouts/gecko/extensions/permissions/PermissionDelegateHandler.cpp, line 348
[task 2020-08-28T21:09:01.085Z] 21:09:01 INFO - GECKO(3767) | [Child 4182: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (0x7f4f34880800) [pid = 4182] [serial = 3] [outer = 0x7f4f4aa93520]
[task 2020-08-28T21:09:01.086Z] 21:09:01 INFO - GECKO(3767) | [Child 4266, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp, line 626
[task 2020-08-28T21:09:01.086Z] 21:09:01 INFO - FrontProgress: onLocationChange http://example.org/browser/browser/base/content/test/general/alltabslistener.html
[task 2020-08-28T21:09:01.090Z] 21:09:01 INFO - TEST-PASS | browser/base/content/test/general/browser_alltabslistener.js | Got an expected notification for the front notifications listener - 3 < 5 -
[task 2020-08-28T21:09:01.090Z] 21:09:01 INFO - Not taking screenshot here: see the one that was previously logged

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Bogdan Tara[:bogdan_tara | bogdant]]

This seems to perma fail on Central, Tier 2: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&collapsedPushes=719443%2C719327%2C719506%2C726551%2C726928%2C729538%2C748815%2C748704%2C748957%2C750516%2C750017%2C749744&group_state=expanded&selectedTaskRun=MLdZdQdRQfmDuvXDwgOHLA.0&fromchange=fdf95334aded3175771c724e785fb148f95ed10b&searchStr=windows%2C10%2Cx64%2Cshippable%2Copt%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-windows10-64-shippable%2Fopt-mochitest-browser-chrome-fis-e10s%2Cbc1&tochange=29ba77e279e4346ecf071b81c8fb171115b266d1

Comment 3

[Intermittent Failures Robot]

17 failures in 166 pushes (0.102 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 4
• mozilla-central: 13

Platform breakdown:

• linux1804-64: 5
• windows10-64-shippable-qr: 5
• windows10-64-shippable: 5
• linux1804-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1661833&startday=2020-08-29&endday=2020-08-29&tree=all

Comment 4

[Cristina Coroiu [:ccoroiu]]

Retriggers on central:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&collapsedPushes=719443%2C719327%2C719506%2C726551%2C726928%2C729538%2C748815%2C748704%2C748957%2C750516%2C750017%2C749744&group_state=expanded&fromchange=ced8e8e8322c3926439b0b138fe75e44099265a7&searchStr=windows%2C10%2Cx64%2Cshippable%2Copt%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-windows10-64-shippable%2Fopt-mochitest-browser-chrome-fis-e10s%2Cbc1&tochange=29ba77e279e4346ecf071b81c8fb171115b266d1

Continued on autoland:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cshippable%2Copt%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-windows10-64-shippable%2Fopt-mochitest-browser-chrome-fis-e10s%2Cbc1&tochange=fdf95334aded3175771c724e785fb148f95ed10b&fromchange=d3abe25ade22d965cfa2c163c4f70dc665204ed0&selectedTaskRun=Zmxi_6nGRsu28na5r4qK0A.0

Comment 5

[Razvan Maries]

Continued retriggers: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2Cshippable%2Copt%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-windows10-64-shippable%2Fopt-mochitest-browser-chrome-fis-e10s%2Cbc1&fromchange=f141529fdcbb256bd7b161d0b0ef1bcc26abb963&tochange=fbd07f0d19d2009779ebde0c676fcbce64607371&selectedTaskRun=PyeVluAARNSkh8bJulLYuA.0

Anny, could you take a look?

Comment 6

[Intermittent Failures Robot]

42 failures in 4046 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #16 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 18
• mozilla-central: 24

Platform breakdown:

• linux1804-64: 15
• windows10-64-shippable-qr: 6
• windows10-64-shippable: 18
• linux1804-64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1661833&startday=2020-08-24&endday=2020-08-30&tree=all

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1589102

Comment 8

[Anny Gakhokidze [:annyG]]

Hi, looking into this!

Comment 9

[Intermittent Failures Robot]

28 failures in 762 pushes (0.037 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 17
• mozilla-central: 11

Platform breakdown:

• linux1804-64: 18
• linux1804-64-shippable: 3
• windows10-64-shippable: 3
• windows10-64-shippable-qr: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1661833&startday=2020-08-31&endday=2020-08-31&tree=all

Comment 10

[Andreea Pavel [:apavel]]

This is now perma-failing on tier1: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=cCddP1xLS8qNRvgq-dmazA.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=64efed429f67a5f929e044fcc3f3a402101af7dd

If there is no fix here until tomorrow the latest, we will disable it on fission.
Thank you.

Ni Razvan for the fyi.

Comment 11

[Razvan Maries]

Attachment: Bug 1661833 - Disabled browser_alltabslistener.js on fission. r?#intermittent-reviewers

Comment 12

[Intermittent Failures Robot]

33 failures in 809 pushes (0.041 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 18
• mozilla-central: 14
• try: 1

Platform breakdown:

• linux1804-64: 22
• windows10-64-shippable-qr: 4
• windows10-64-shippable: 4
• linux1804-64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1661833&startday=2020-09-01&endday=2020-09-01&tree=all

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98c4825fc36c
Disabled browser_alltabslistener.js on fission. r?#intermittent-reviewers

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/98c4825fc36c

Comment 15

[Intermittent Failures Robot]

23 failures in 836 pushes (0.028 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 16
• mozilla-central: 7

Platform breakdown:

• linux1804-64: 18
• windows10-64-shippable: 2
• windows10-64-shippable-qr: 2
• linux1804-64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1661833&startday=2020-09-02&endday=2020-09-02&tree=all

Comment 16

[Intermittent Failures Robot]

88 failures in 2984 pushes (0.029 failures/push) were associated with this bug in the last 7 days.

This is the #6 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 51
• mozilla-central: 32
• try: 5

Platform breakdown:

• linux1804-64: 61
• linux1804-64-shippable: 7
• windows10-64-shippable: 9
• windows10-64-shippable-qr: 10
• windows10-64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1661833&startday=2020-08-31&endday=2020-09-06&tree=all

Comment 17

[Anny Gakhokidze [:annyG]]

This potentially might depend on bug 1668864

Comment 18

[Anny Gakhokidze [:annyG]]

:kmag suggested that instead of keeping mSuspendedProgressEvents in BrowserParent, we can do the following

So, I'd say we should either store the flag on FrameLoaderOwner and copy it to the BrowserParent when we initialize the remote browser here or add a helper to grab the owner element and cast it to a FrameLoaderOwner in the places where we check the flag such as here though that'll be a bit tricky if we have to handler OOP iframes where we'll have a BrowserBridgeParent rather than a FrameLoaderOwner

Some observations:

• mSuspendedProgressEvents flag is used in BrowserParent whenever we receive any progress events, in methods BrowserParent::RecvOnStateChange, BrowserParent::RecvOnProgressChange, BrowserParent::RecvOnLocationChange, BrowserParent::RecvOnStatusChange. We can start storing this flag on nsFrameLoaderOwner and BrowserBridgeParent so that whenever BrowserParent needs to access it, it can cast its owner element to either nsFrameLoaderOwner or BrowserBridgeParent and retrieve the flag that way.
• mSuspendedProgressEvents is modified in the following cases:
  • In nsFrameLoader::StartDestroy. Here if we have a BrowserParent available that means the nsFrameLoader corresponds to the top level document and we are currently in the parent process. Modify the flag on nsFrameLoaderOwner.
  • In nsFrameLoaderOwner::ChangeRemotenessCommon . Same as above
  • In DocumentLoadListener::TriggerProcessSwitch. Before we get the BrowserParent we ensure that WindowGlobalParent::IsProcessRoot returns true. Do the same thing as above.
  • In DocumentLoadListener::OnStartRequest. Depends on what the owner element is.

I will extract setting of the flag into its own function on BrowserParent that will do the right thing based on its owner element.

Comment 19

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1661833 - Suspend progress events when process switching

Comment 20

[Anny Gakhokidze [:annyG]]

Attachment: Bug 1661833 - Fix duplicate OnStateChange events during process switches, r=nika!

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ad5891e7cc0
Fix duplicate OnStateChange events during process switches, r=nika

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cc476b645cc
Fix ESlint prettier error. r=nbeleuzu CLOSED TREE

Comment 23

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6ad5891e7cc0
https://hg.mozilla.org/mozilla-central/rev/0cc476b645cc