1661834 - [wpt-sync] Sync PR 25280 - Fix incorrect delay of DelayNode

Status: NEW

(Core :: Web Audio, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 25280 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25280
Details from upstream follow.

b'Raymond Toy <[e-mail]>' wrote:

Fix incorrect delay of DelayNode

WrapPositionVector was not wrapping the position around when it equaled
the end of the buffer. This caused an extra zero value to be output
in this case.

Examination of WrapIndexVector also indicates a related logic error
because there's no >= intrinsic, so we used \< but got the logic wrong.

The NEON version appears to be correct, so just added additional
comments to match the SSE2 version.

Added one test to make sure the delay is correct (based on the bug
report).

Bug: 1123023
Test: the-delaynode-interface/delay-test.html
Change-Id: Ibcb09573c53d62e926a332307d07601110b91aa3

Reviewed-on: https://chromium-review.googlesource.com/2382656
WPT-Export-Revision: a7bf2fb31ea935d04d028189c6346f1252240824

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=77f258a36f805a8a30751539029284088cff797f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 13 subtests

Status Summary

Firefox

OK : 1
PASS: 10

Chrome

OK : 1
PASS: 7
FAIL: 3

Safari

OK : 1
PASS: 4
FAIL: 1

Links

GitHub PR Head
GitHub PR Base