1661861 - Warp: Generate arguments rectifier for trial inlining

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Iain Ireland [:iain]]

After it has pushed the right arguments, the arguments rectifier loads the jitcode address from the callee. This doesn't work with BaselineCacheIRCompiler::CallInlinedFunction, which has to call the baseline version of the code.

The fix is to generate a second copy of the arguments rectifier to use when calling trial-inlined functions. This allows us to trial-inline functions that are called with missing arguments, and also removes an obstacle to inlining FunApply and spread calls.

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1661861: Generate arguments rectifier for trial inlining r=jandem

We don't have to store a separate return offset for trial inlining, because the rectifier code after returning from the call is exactly the same. Post-bailout, inline frames will return into the normal non-inline code.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0911c872a1f6
Generate arguments rectifier for trial inlining r=jandem

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0911c872a1f6