1661874 - More ColumnSet cleanup

Status: RESOLVED FIXED

(Core :: Layout: Columns, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

+++ This bug was initially created as a clone of Bug #1618646 +++

After supporting column-span, nsColumSetFrame isn't the top-level multicol container anymore. We can simplify its logic a bit.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1661874 Part 1 - Rename mColMaxBSize to mColBSize in ReflowConfig.

Rename so that its naming is consistent with ReflowConfig::mColISize,
and to avoid confusion with ColumnBalanceData::mMaxBSize.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1661874 Part 2 - Remove the support of ColumnSetFrame being an abs.pos container.

The support of this was added in
https://hg.mozilla.org/mozilla-central/rev/fb0790d28846

After supporting column-span, ColumnSetFrame isn't the top-level
multicol container anymore, and is not served as an abs.pos container.
Thus, we can simply the reflow code a bit.

Depends on D88697

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1661874 Part 3 - Reverse the meaning of skipIncremental and rename it.

I feel skipIncremental is hard to reasoning. It's easier to list all the
possible reasons that the child needs to be reflowed again.

Depends on D88698

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1661874 Part 4 - Simplify the condition to set colData.mHasExcessBSize to true.

nsColumnSetFrame's ComputedBSize() and ComputedMaxBSize() are always
NS_UNCONSTRAINEDSIZE.

Depends on D88699

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bc1452132f5
Part 1 - Rename mColMaxBSize to mColBSize in ReflowConfig. r=heycam
https://hg.mozilla.org/integration/autoland/rev/d1bacf3c0f3f
Part 2 - Remove the support of ColumnSetFrame being an abs.pos container. r=heycam
https://hg.mozilla.org/integration/autoland/rev/84313d82b10a
Part 3 - Reverse the meaning of skipIncremental and rename it. r=heycam
https://hg.mozilla.org/integration/autoland/rev/cc4b6a85883f
Part 4 - Simplify the condition to set colData.mHasExcessBSize to true. r=heycam

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6bc1452132f5
https://hg.mozilla.org/mozilla-central/rev/d1bacf3c0f3f
https://hg.mozilla.org/mozilla-central/rev/84313d82b10a
https://hg.mozilla.org/mozilla-central/rev/cc4b6a85883f