1661895 - [ja] Keyboard shortcut(Ctrl+;) for Zoom-In stops working since Firefox80 ja win64 build with JIS keyboard

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Alice0775 White]

[Tracking Requested - why for this release]: Zoom-IN using Keyboard shortcut(Ctrl+;) is broken in ja win64 build with JIS keyboard

Steps To Reproduce:

1. Zoom-IN using Keyboard shortcut(Ctrl+;)

Actual Results:
Nothing happens

Expected Results:
Page should be zoomed-in

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=84b257d07031f657765a63f137f17b1f1c6587d7&tochange=255b4f5888e9e9cdd40f59fec969af247859d76a
https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=4b7dd68351168e3204b81edf188c12cfcaa85492&tochange=2f7d9a147be6a405b200b05cabf764103f437c88

Comment 1

[Alice0775 White]

the offending patch seems to be https://hg.mozilla.org/l10n-central/ja/rev/3cf0c3bc1acc

Comment 2

[ABE Hiroki (:hATrayflood)]

oh, sorry for my missunderstood. I fixed it in l10n-ja github repo. thanks.
https://github.com/mozilla-japan/gecko-l10n/pull/217

Comment 3

[Masahiko Imanaka [:marsf]]

Fixed on Fx81 and later:
https://hg.mozilla.org/l10n-central/ja/rev/9128f0c4ac87443b34dd2fd15bd497683ea1f0d6
https://hg.mozilla.org/l10n-central/ja-JP-mac/rev/481cff7a7a8a1cab3e76616e240814ca0aa207b0

Comment 4

[Alice0775 White]

[Tracking Requested - why for this release]: beta81.0b3 is also affected.

I can verify fix on Nightly82.0a1(20200829212302) ja Win64 build.

Comment 5

[Masahiko Imanaka [:marsf]]

Verified fixed on Beta 81.0b4 (20200829200810).

Please change this status.

Comment 6

[Julien Cristau [:jcristau]]

Francesco, do you think we can update the rev on m-r to fix this in 80.0.1?

Comment 7

[Francesco Lodolo [:flod]]

It can be done with relatively small risk, someone needs to update l10n-changesets.json on mozilla-release with a more recent changeset for ja and ja-JP-mac.

Current:

• ja: 64e0120475c4
• ja-JP-mac: 95744099e14a

Beta has:

• ja: 9128f0c4ac87443b34dd2fd15bd497683ea1f0d6
• ja-JP-mac: 481cff7a7a8a1cab3e76616e240814ca0aa207b0

I guess we moved to long hashes with the recent change to l10n-bumper.
https://hg.mozilla.org/releases/mozilla-beta/file/4395dbeee831c2ec5feba0e7222c50e0bf78688c/browser/locales/l10n-changesets.json#l884

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-release/rev/f752e1ef0385

Comment 9

[Negritas Sergiu, Desktop QA]

Hello I have tried to reproduce the issue using Windows 10 x64 with Japanese imput keyboard on Firefox 79.0 and 80.0 Ja locale but without success.

Could you please direct me if I'm missing something in reproducing this issue ?

I can confirm that the zooming works on Firefox 80.0.1 with Windows 10 x64 with Japanese imput keyboard.

Masahiko can you please verify if the issue is fixed using the build provided in the following link? http://archive.mozilla.org/pub/firefox/candidates/80.0.1-candidates/build1/

Comment 10

[Masahiko Imanaka [:marsf]]

(In reply to Negritas Sergiu from comment #9)

Hello I have tried to reproduce the issue using Windows 10 x64 with Japanese imput keyboard on Firefox 79.0 and 80.0 Ja locale but without success.

Could you please direct me if I'm missing something in reproducing this issue ?

I can confirm that the zooming works on Firefox 80.0.1 with Windows 10 x64 with Japanese imput keyboard.

Hi, you should read comments above.
This is just a Japanese locale bug. Firefox 79.0 doesn't have this issue, and 80.0.1 has been fixed.
If you want to reproduce this issue, try Firefox 80.0.0 with Japanese locale.

Comment 11

[Negritas Sergiu, Desktop QA]

Hello I managed to reproduce the issue with Firefox 80.0.0 ja locale on windows 10 x64 with japanese imput keyboard.
I can confirm that the issue is fixed in 80.0.1 with Windows 10 x64 and japanese imput keyboard.