1661920 - Perma late beta /html/canvas/element/path-objects/2d.path.isPointInPath.basic.html | Verify the winding rule in isPointInPath works for for rect path. - assert_equals: ctx.isPointInPath(0, 0, 'nonzero') === false when Gecko 82 merges to Beta on 2020-09-21

Status: VERIFIED FIXED

(Testing :: web-platform-tests, defect)

Description

[Cristian Brindusan [:cbrindusan]]

Central as Beta simulation

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=f61a8c17d8cce03329e3fefc5dc5b5a4c7f1c7bf&selectedTaskRun=MqRN7tuURKOajTsiz6h1AA.0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314366499&repo=try&lineNumber=3387

[task 2020-08-29T11:41:15.384Z] 11:41:15 INFO - TEST-START | /html/canvas/element/path-objects/2d.path.isPointInPath.basic.html
[task 2020-08-29T11:41:15.394Z] 11:41:15 INFO - Closing window 1207
[task 2020-08-29T11:41:15.511Z] 11:41:15 INFO -
[task 2020-08-29T11:41:15.511Z] 11:41:15 INFO - TEST-UNEXPECTED-FAIL | /html/canvas/element/path-objects/2d.path.isPointInPath.basic.html | Verify the winding rule in isPointInPath works for for rect path. - assert_equals: ctx.isPointInPath(0, 0, 'nonzero') === false (got true[boolean], expected false[boolean]) expected false but got true

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

there are 2 problems there:
TEST-UNEXPECTED-FAIL | /html/canvas/element/path-objects/2d.path.isPointInPath.basic.html | Verify the winding rule in isPointInPath works for for rect path. - assert_equals: ctx.isPointInPath(0, 0, 'nonzero') === false (got true[boolean], expected false[boolean]) expected false but got true
TEST-UNEXPECTED-PASS | /html/canvas/element/path-objects/2d.path.isPointInStroke.scaleddashes.html | isPointInStroke() should return correct results on dashed paths at high scale factors - expected FAIL

I can create a patch to fix this

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: Bug 1661920 - Adjust wpt expectations for 2d.path.isPointIn<Path.basic/Stroke.scaleddashes>.html in beta.

adjust wpt expectations for beta

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0731942ca1fa
Adjust wpt expectations for 2d.path.isPointIn<Path.basic/Stroke.scaleddashes>.html in beta. r=jmaher

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0731942ca1fa

Comment 5

[Cristina Coroiu [:ccoroiu]]

Verified as fixed with today's beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5ae008bd5e734293919c17b1b92034dbb9f254e&searchStr=Windows%2C10%2Cx64%2CWebRender%2CShippable%2Copt%2CWeb%2Cplatform%2Ctests%2Ctest-windows10-64-shippable-qr%2Fopt-web-platform-tests-e10s%2Cwpt8&selectedTaskRun=bQ2tohFETxuzSPKJgz22TQ.0