Closed Bug 1661993 Opened 1 year ago Closed 1 year ago

Use PWG standardized names in fallback paper list on GTK

Categories

(Core :: Printing: Setup, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox81 --- fixed
firefox82 --- fixed

People

(Reporter: nordzilla, Assigned: nordzilla)

Details

(Whiteboard: [print2020_v81])

Attachments

(1 file)

When we use the fallback paper list for printing to PDF, we need to set the paper name in the print settings.

Using the localized paper name for GTK print settings will cause issues due to the following GTK code, which expects PWG standardized names:

https://github.com/GNOME/gtk/blob/master/gtk/gtkpapersize.c#L261

The simplest is just to use PWG standardized names for GTK code, and localized names elsewhere, differentiated where the list is defined.

This patch ensures that our fallback paper list (used for print saving
as PDF) will use PWG standardized names for the paper sizes for GTK
print settings.

Attachment #9172929 - Attachment description: Bug 1661993 - Use PWG Standardized paper names for GTK r=jwatt,alaskanemily,sfoster → Bug 1661993 - Use PWG Standardized paper names for GTK r=jwatt,alaskanemily,sfoster, jfkthame
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/482741a9df29
Use PWG Standardized paper names for GTK r=sfoster
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

Comment on attachment 9172929 [details]
Bug 1661993 - Use PWG Standardized paper names for GTK r=jwatt,alaskanemily,sfoster, jfkthame

Beta/Release Uplift Approval Request

  • User impact if declined: Selecting paper sizes in the print UI will not work on Linux.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The code that will use this functionality has not yet landed, and if there were to be an error in this patch it would just mean paper size selection would continue to not work on Linux.
  • String changes made/needed:
Attachment #9172929 - Flags: approval-mozilla-beta?

Comment on attachment 9172929 [details]
Bug 1661993 - Use PWG Standardized paper names for GTK r=jwatt,alaskanemily,sfoster, jfkthame

Approved for 81.0b5.

Attachment #9172929 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.