1662014 - Delete unused codepaths for scroll update propagation

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task)

Description

[Kartikaya Gupta (email:[e-mail])]

After bug 1662013 there's a bunch of code we can remove, because it gets replaced by the ScrollPositionUpdate array. I'm mostly splitting this out into a separate bug because there's a patch for bug 1661903 "in between" the patches for bug 1662013 and this bug, and also so that I can land this a bit more incrementally.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1662014 - Stop using the mSmoothScrollOffset field. r?botond

This is the only place that uses the mSmoothScrollOffset any more, and it
doesn't really need to as a local variable suffices.

Depends on D88747

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1662014 - Update some TiledContentClient code to use the ScrollPositionUpdate array. r?botond

This should be mostly equivalent to the old code, and unblocks deletion of
some fields in FrameMetrics.

Depends on D88748

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1662014 - Remove unused fields/APIs. r?botond,tnikkel

These things are all unused now.

Depends on D88749

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1662014 - Drop mRelativeOffset and mLastSmoothScrollOrigin. r?tnikkel,botond

The only place these fields are still read are for detecting if an APZ animation
is pending (not yet submitted in a transaction) and we can replace that code
with something simpler. And then delete the unused fields.

Depends on D88750

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67d2d087ca1c
Stop using the mSmoothScrollOffset field. r=botond
https://hg.mozilla.org/integration/autoland/rev/d13968a06d1f
Update some TiledContentClient code to use the ScrollPositionUpdate array. r=botond
https://hg.mozilla.org/integration/autoland/rev/c8c899745993
Remove unused fields/APIs. r=botond,tnikkel
https://hg.mozilla.org/integration/autoland/rev/afe9bfd9f1ab
Drop mRelativeOffset and mLastSmoothScrollOrigin. r=tnikkel,botond

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/67d2d087ca1c
https://hg.mozilla.org/mozilla-central/rev/d13968a06d1f
https://hg.mozilla.org/mozilla-central/rev/c8c899745993
https://hg.mozilla.org/mozilla-central/rev/afe9bfd9f1ab