1662054 - Add a destroy function to targetList

Status: RESOLVED FIXED

(DevTools :: Framework, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

At the moment, we don't have any guards in the targetList to not execute the creation/destruction listeners once the toolbox gets destroyed.
We only have a stopListening function on the targetList that is called when we close the toolbox, but we can't rely only on that since it's also called when doing a target switch (and working around that is very racy).

One solution would be to follow the common pattern we have everywhere by having a destroy method that we would check before trying to call the listeners callback.

This might help with intermittent.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1662054 - Add a destroy function to targetList. r=jdescottes.

At the moment, we don't have any guards in the targetList to not execute the
creation/destruction listeners once the toolbox gets destroyed.
We only have a stopListening function on the targetList that is called when we
close the toolbox, but we can't rely only on that since it's also called when
doing a target switch (and working around that is very racy).

One solution would be to follow the common pattern we have everywhere by having
a destroy method that we would check before trying to call the listeners callback.

This might help with intermittent test failures.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b8ca74d313f
Add a destroy function to targetList. r=jdescottes.

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9b8ca74d313f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172970 [details]
Bug 1662054 - Add a destroy function to targetList. r=jdescottes.

Needed for bug 1660466. Approved for 81.0b8.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7b2b2884929c