1662122 - Implement dispatcher & IPC for timespans

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Jan-Erik Rediger [:janerik]]

We need IPC support and use of the dispatcher for timespans in FOG

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1662122 - Dispatch timespan metric recording. r?chutten!

Depends on D88842

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1662122 - Implement IPC for timespan metrics. r?chutten!

Depends on D88843

Comment 3

[Jan-Erik Rediger [:janerik]]

Patches are abandoned for now.
We'll land that separately from the other changes. There's no actual blocker in how the code looks (no need for a timer id!)

Comment 4

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1662122 - Dispatch timespan metric recording. r?chutten!

Comment 5

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1662122 - Implement IPC for timespan metrics. r?chutten!

Depends on D90848

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/060270c0220f
Dispatch timespan metric recording. r=chutten
https://hg.mozilla.org/integration/autoland/rev/86d5740e32a2
Implement IPC for timespan metrics. r=chutten

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out together with bug 1662123, more details there.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47e17a661b8e
Dispatch timespan metric recording. r=chutten
https://hg.mozilla.org/integration/autoland/rev/a05a1b934110
Implement IPC for timespan metrics. r=chutten

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 4 changesets (bug 1662123, bug 1662122) for RustMozCrash raptor crashes.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=ZN-fyrcjTVC5IGkzsIfekw.0&searchStr=windows%2C7%2Cshippable%2Copt%2Craptor%2Cperformance%2Ctests&fromchange=7d65816fd603696ae6483bdefa525c3611776208&tochange=bb508d4f63d96027b87e4b427f247c5d22294abc

Backout link: https://hg.mozilla.org/integration/autoland/rev/21737332f18cf6e65bb4cef1091082cdb88a70d6

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=316934711&repo=autoland&lineNumber=1009

[task 2020-09-28T17:58:22.380Z] 17:58:22     INFO -  raptor-webext Info: installing webext C:\Users\task_1601314115\build\tests\raptor\raptor\webextension\..\..\webext\raptor
[task 2020-09-28T17:58:22.385Z] 17:58:22     INFO -  raptor-webext-desktop Info: starting firefox
[task 2020-09-28T17:58:22.385Z] 17:58:22     INFO -  Application command: C:\Users\task_1601314115\build\application\firefox\firefox.exe --allow-downgrade --wait-for-browser -profile c:\users\task_1601314115\appdata\local\temp\tmphanytq\profile
[task 2020-09-28T17:58:24.302Z] 17:58:24     INFO -  raptor-control-server Info: received webext_loaded: raptor runner.js is loaded!
[task 2020-09-28T17:58:24.332Z] 17:58:24     INFO -  raptor-control-server Info: received webext_status: testing on Firefox 83.0a1 20200928155610
[task 2020-09-28T17:58:24.351Z] 17:58:24     INFO -  raptor-control-server Info: received webext_status: test name is: raptor-tp6-amazon-firefox-cold
[task 2020-09-28T17:58:24.361Z] 17:58:24     INFO -  raptor-control-server Info: received webext_status: test settings url is: http://127.0.0.1:49879/json/raptor-tp6-amazon-firefox-cold.json
[task 2020-09-28T17:58:24.363Z] 17:58:24     INFO -  raptor-control-server Info: received webext_status: starting raptorRunner
[task 2020-09-28T17:58:24.373Z] 17:58:24     INFO -  PID 7188 | console.info: "[raptor-runnerjs] getting test settings from control server"
[task 2020-09-28T17:58:24.374Z] 17:58:24     INFO -  raptor-control-server Info: reading test settings from json/raptor-tp6-amazon-firefox-cold.json
[task 2020-09-28T17:58:24.374Z] 17:58:24     INFO -  raptor-control-server Info: sent test settings to webext runner
[task 2020-09-28T17:58:24.379Z] 17:58:24     INFO -  PID 7188 | console.info: "[raptor-runnerjs] test settings received: {\"raptor-options\": {\"expected_browser_cycles\": 25, \"subtest_unit\": \"ms\", \"alert_threshold\": 2.0, \"type\": \"pageload\", \"page_cycles\": 1, \"subtest_lower_is_better\": true, \"alert_on\": [\"fcp\", \"loadtime\"], \"test_url\": \"https://www.amazon.com/s?k=laptop&ref=nb_sb_noss_1\", \"page_timeout\": 60000, \"host\": \"127.0.0.1\", \"measure\": {\"fcp\": true, \"dcf\": true, \"fnbpaint\": true, \"loadtime\": true}, \"cold\": true, \"lower_is_better\": true, \"unit\": \"ms\"}}"
[task 2020-09-28T17:58:24.379Z] 17:58:24     INFO -  PID 7188 | console.info: "[raptor-runnerjs] test URL: https://www.amazon.com/s?k=laptop&ref=nb_sb_noss_1"
[task 2020-09-28T17:58:24.379Z] 17:58:24     INFO -  PID 7188 | console.info: "[raptor-runnerjs] using page timeout: 60000ms"
[task 2020-09-28T17:58:24.458Z] 17:58:24     INFO -  raptor-control-server Info: received webext_status: * pausing 1 seconds to let browser settle... *
[task 2020-09-28T17:58:24.458Z] 17:58:24     INFO -  PID 7188 | console.info: "[raptor-runnerjs] wrote settings to ext local storage"
[task 2020-09-28T17:58:24.458Z] 17:58:24     INFO -  PID 7188 | console.info: "[raptor-runnerjs] pageload test start"
[task 2020-09-28T18:00:38.956Z] 18:00:38     INFO -  mozcrash Downloading symbols from: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Ov-7QTE-RZKYdNGQn0_bDQ/artifacts/public/build/target.crashreporter-symbols.zip
[task 2020-09-28T18:00:42.514Z] 18:00:42     INFO -  mozcrash Copy/paste: C:/Users/task_1601314115/fetches\minidump_stackwalk\minidump_stackwalk.exe c:\users\task_1601314115\appdata\local\temp\tmphanytq\profile\minidumps\caa15399-f284-4e48-b0ee-bf45c1df63c3.dmp c:\users\task_1601314115\appdata\local\temp\tmp83ml44
[task 2020-09-28T18:00:51.000Z] 18:00:51     INFO -  mozcrash Saved minidump as C:\Users\task_1601314115\build\blobber_upload_dir\caa15399-f284-4e48-b0ee-bf45c1df63c3.dmp
[task 2020-09-28T18:00:51.000Z] 18:00:51     INFO -  mozcrash Saved app info as C:\Users\task_1601314115\build\blobber_upload_dir\caa15399-f284-4e48-b0ee-bf45c1df63c3.extra
[task 2020-09-28T18:00:51.003Z] 18:00:51    ERROR -  PROCESS-CRASH | runner.py | application crashed [@ RustMozCrash(char const*, int, char const*)]
[task 2020-09-28T18:00:51.003Z] 18:00:51     INFO -  Mozilla crash reason: Global Glean object not initialized
[task 2020-09-28T18:00:51.004Z] 18:00:51     INFO -  Crash dump filename: c:\users\task_1601314115\appdata\local\temp\tmphanytq\profile\minidumps\caa15399-f284-4e48-b0ee-bf45c1df63c3.dmp
[task 2020-09-28T18:00:51.004Z] 18:00:51     INFO -  Operating system: Windows NT
[task 2020-09-28T18:00:51.005Z] 18:00:51     INFO -                    10.0.17134
[task 2020-09-28T18:00:51.005Z] 18:00:51     INFO -  CPU: x86
[task 2020-09-28T18:00:51.005Z] 18:00:51     INFO -       GenuineIntel family 6 model 94 stepping 3
[task 2020-09-28T18:00:51.005Z] 18:00:51     INFO -       8 CPUs
[task 2020-09-28T18:00:51.006Z] 18:00:51     INFO -  GPU: UNKNOWN
[task 2020-09-28T18:00:51.006Z] 18:00:51     INFO -  Crash reason:  EXCEPTION_BREAKPOINT
[task 2020-09-28T18:00:51.006Z] 18:00:51     INFO -  Crash address: 0x647ac1d1
[task 2020-09-28T18:00:51.006Z] 18:00:51     INFO -  Process uptime: 2 seconds
[task 2020-09-28T18:00:51.007Z] 18:00:51     INFO -  Thread 82 (crashed)
[task 2020-09-28T18:00:51.007Z] 18:00:51     INFO -   0  xul.dll!RustMozCrash(char const*, int, char const*) [wrappers.cpp:9be1472b4231c7c5c25d6f2f09c86c4aa7223a8a : 16 + 0x11]
[task 2020-09-28T18:00:51.007Z] 18:00:51     INFO -      eip = 0x647ac1d1   esp = 0x1fd7f0e0   ebp = 0x1fd7f0e0   ebx = 0x00000023
[task 2020-09-28T18:00:51.007Z] 18:00:51     INFO -      esi = 0x69493f14   edi = 0x00000027   eax = 0x1fd7f2fa   ecx = 0x0000001f
[task 2020-09-28T18:00:51.007Z] 18:00:51     INFO -      edx = 0x6b356198   efl = 0x00000202
[task 2020-09-28T18:00:51.008Z] 18:00:51     INFO -      Found by: given as instruction pointer in context
[task 2020-09-28T18:00:51.008Z] 18:00:51     INFO -   1  xul.dll!mozglue_static::panic_hook(core::panic::PanicInfo*) [lib.rs:9be1472b4231c7c5c25d6f2f09c86c4aa7223a8a : 89 + 0xa]
[task 2020-09-28T18:00:51.008Z] 18:00:51     INFO -      eip = 0x6812c0ee   esp = 0x1fd7f0e8   ebp = 0x1fd7f50c
[task 2020-09-28T18:00:51.008Z] 18:00:51     INFO -      Found by: call frame info
[task 2020-09-28T18:00:51.009Z] 18:00:51     INFO -   2  xul.dll!core::ops::function::Fn::call<fn(core::panic::PanicInfo*),(core::panic::PanicInfo*)>(void (**)(core::panic::PanicInfo*), core::panic::PanicInfo*) [function.rs:4fb7144ed159f94491249e86d5bbd033b5d60550 : 232 + 0xb]
[task 2020-09-28T18:00:51.009Z] 18:00:51     INFO -      eip = 0x6812c02b   esp = 0x1fd7f514   ebp = 0x1fd7f514   ebx = 0x694cb898
[task 2020-09-28T18:00:51.009Z] 18:00:51     INFO -      esi = 0x1fd7f550   edi = 0x6952c954
[task 2020-09-28T18:00:51.009Z] 18:00:51     INFO -      Found by: call frame info
[task 2020-09-28T18:00:51.010Z] 18:00:51     INFO -   3  xul.dll!std::panicking::rust_panic_with_hook() [panicking.rs:4fb7144ed159f94491249e86d5bbd033b5d60550 : 474 + 0x11]
[task 2020-09-28T18:00:51.010Z] 18:00:51     INFO -      eip = 0x682b71e4   esp = 0x1fd7f51c   ebp = 0x00000001
[task 2020-09-28T18:00:51.010Z] 18:00:51     INFO -      Found by: call frame info
[task 2020-09-28T18:00:51.010Z] 18:00:51     INFO -   4  xul.dll!trunc + 0x67da72
[task 2020-09-28T18:00:51.011Z] 18:00:51     INFO -      eip = 0x69493f04   esp = 0x1fd7f598   ebp = 0x1fd7f5d4   ebx = 0x682bbf99
[task 2020-09-28T18:00:51.011Z] 18:00:51     INFO -      esi = 0x16390454   edi = 0x1fd7f634
[task 2020-09-28T18:00:51.011Z] 18:00:51     INFO -      Found by: call frame info

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35cd80ab7cfa
Dispatch timespan metric recording. r=chutten
https://hg.mozilla.org/integration/autoland/rev/064de0eee2e7
Implement IPC for timespan metrics. r=chutten

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/35cd80ab7cfa
https://hg.mozilla.org/mozilla-central/rev/064de0eee2e7