1662191 - about:webrtc "save page" button is broken on Android

Status: REOPENED

(GeckoView :: General, defect, P3)

Description

[Byron Campen [:bwc]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1662036#c3, I can verify on my own phone also. Not sure when this broke, I have verified on 82 though.

Comment 1

[Byron Campen [:bwc]]

This happens on 79 and 80 too. I'm guessing 81 will be affected, but have been unable to check.

Comment 2

[Byron Campen [:bwc]]

I should note that the Export button on about:certificate seems to be working fine; it seems to be using an "open file" dialog instead of the "file picker" that both about:webrtc and about:memory use. Does FilePicker not work on Android?

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Bump since this is marked S2. Hi James, do you know the answer to comment 2?

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Byron Campen [:bwc] from comment #2)

I should note that the Export button on about:certificate seems to be working fine; it seems to be using an "open file" dialog instead of the "file picker" that both about:webrtc and about:memory use. Does FilePicker not work on Android?

Yeah, I would not be surprised if nsIFilePicker did not work on Android. It might be possible to get it going, as we do have APIs for file selection exposed to the app.

Comment 5

[Nils Ohlmeier [:drno]]

Based on comment #4 this appears to be a Fenix bug, because of lack of support for nsIFilePicker.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Please move this to https://github.com/mozilla-mobile/android-components/ Fenix:Stability is not a dumping ground for general Fenix/AC issues.

Comment 7

[Arturo Mejia [:amejia]]

(In reply to James Willcox (:snorp) ([e-mail]) (he/him) from comment #4)

(In reply to Byron Campen [:bwc] from comment #2)

I should note that the Export button on about:certificate seems to be working fine; it seems to be using an "open file" dialog instead of the "file picker" that both about:webrtc and about:memory use. Does FilePicker not work on Android?

Yeah, I would not be surprised if nsIFilePicker did not work on Android. It might be possible to get it going, as we do have APIs for file selection exposed to the app.

James, is there any api that we have to support on ac for nsIFilePicker to work? We already implemented onFilePrompt but it looks like we will need to implement another api.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

nsIFilePicker has some additional stuff that we could either add to the existing FilePrompt class in GeckoView or ignore. Since it's not a web-visible thing I think we should just try to do the minimum to make it work via onFilePrompt and FilePrompt.

Comment 9

[Chris Peterson [:cpeterson]]

Olivia says this bug is reproducible in Fenix and GVE, but it seems like a low priority.