1662201 - Update history ID to match the docshell ID of the SHEntry

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P2)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1662201 - Update history ID to mach the docshell ID of the SHEntry, r=peterv

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/071c8c9a91f1
Update history ID to mach the docshell ID of the SHEntry, r=peterv

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 071c8c9a91f1 (bug 1662201) for docshell related bustage.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=0c29583ca111f315431284bde955d226ad4d2ba0&searchStr=build&tochange=69f18d1d720cbc800a4dc4858d1f5b08d109f862&selectedTaskRun=XseRV64eR52kbLpIWqgBQA.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/69f18d1d720cbc800a4dc4858d1f5b08d109f862

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314567078&repo=autoland&lineNumber=11532

[task 2020-09-01T13:40:20.350Z] 13:40:20     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/docshell/base'
[task 2020-09-01T13:40:20.355Z] 13:40:20     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 -o Unified_cpp_docshell_base0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/docshell/base -I/builds/worker/workspace/obj-build/docshell/base -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/checkouts/gecko/docshell/shistory -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/dom/bindings -I/builds/worker/checkouts/gecko/js/xpconnect/src -I/builds/worker/checkouts/gecko/layout/base -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/layout/style -I/builds/worker/checkouts/gecko/layout/xul -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/protocol/viewsource -I/builds/worker/checkouts/gecko/toolkit/components/browser -I/builds/worker/checkouts/gecko/toolkit/components/find -I/builds/worker/checkouts/gecko/tools/profiler -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Werror=implicit-function-declaration -Wno-psabi -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_docshell_base0.o.pp   Unified_cpp_docshell_base0.cpp
[task 2020-09-01T13:40:20.356Z] 13:40:20     INFO -  In file included from Unified_cpp_docshell_base0.cpp:38:
[task 2020-09-01T13:40:20.356Z] 13:40:20    ERROR -  /builds/worker/checkouts/gecko/docshell/base/CanonicalBrowsingContext.cpp:312:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result]
[task 2020-09-01T13:40:20.356Z] 13:40:20     INFO -      SetHistoryID(entry->DocshellID());
[task 2020-09-01T13:40:20.357Z] 13:40:20     INFO -      ^~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~
[task 2020-09-01T13:40:20.357Z] 13:40:20     INFO -  1 error generated.
[task 2020-09-01T13:40:20.357Z] 13:40:20     INFO -  /builds/worker/checkouts/gecko/config/rules.mk:723: recipe for target 'Unified_cpp_docshell_base0.o' failed
[task 2020-09-01T13:40:20.357Z] 13:40:20    ERROR -  make[4]: *** [Unified_cpp_docshell_base0.o] Error 1
[task 2020-09-01T13:40:20.357Z] 13:40:20     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/docshell/base'
[task 2020-09-01T13:40:20.357Z] 13:40:20     INFO -  /builds/worker/checkouts/gecko/config/recurse.mk:72: recipe for target 'docshell/base/target-objects' failed
[task 2020-09-01T13:40:20.358Z] 13:40:20    ERROR -  make[3]: *** [docshell/base/target-objects] Error 2
[task 2020-09-01T13:40:20.358Z] 13:40:20     INFO -  make[3]: *** Waiting for unfinished jobs....

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaa9e62c312d
Update history ID to mach the docshell ID of the SHEntry, r=peterv

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/aaa9e62c312d