1662204 - Crash when printing about:sessionrestore

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Emma Malysz]

I don't believe any of the other crash bugs handle this, but I'm seeing nightly crash whenever I print about:sessionrestore. There were a few bugs that covered weird "about" behavior, but this is the only about page that always crashes when printing (as far as I can tell).

Here's my crash report:
https://crash-stats.mozilla.org/report/index/4f9cbb26-8141-4e0b-9d01-4d9390200831

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Interesting one!

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: stack of when the browser getting a presShell

Look at this beauty of a stack!

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1662204 - Prevent all printed documents, not just print preview, from getting a regular non-print presentation. r=jwatt

Before bug 1636728 this couldn't happen because print documents weren't
hosted in an <iframe>. The presentation of documents that are being
printed should be managed by the print job.

We should, in fact, probably just make mDocument->IsStaticDocument() the
condition, or such.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7801d63e36f8
Prevent all printed documents, not just print preview, from getting a regular non-print presentation. r=jwatt

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/7801d63e36f8

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1636728

Comment 7

[Jonathan Watt [:jwatt]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #6)

Set release status flags based on info from the regressing bug 1636728

The question is, are you going to be smart enough to update the flags if bug 1636728 gets uplifted. I'll change status-firefox81 just in case you're not.

Comment 8

[Jonathan Watt [:jwatt]]

Comment on attachment 9173199 [details]
Bug 1662204 - Prevent all printed documents, not just print preview, from getting a regular non-print presentation. r=jwatt

Beta/Release Uplift Approval Request

• User impact if declined: Crash fix.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): crash fix
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173199 [details]
Bug 1662204 - Prevent all printed documents, not just print preview, from getting a regular non-print presentation. r=jwatt

Approved for 81.0b6.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8445f30917c3

Comment 11

[Emil Ghitta, QA [:emilghitta]]

Reproduced this issue using Firefox 82.0a1 (BuildId:20200831215215).

This issue is verified fixed using Firefox 81.0b7 (BuildId:20200906164749) and Firefox 82.0a1 (BuildId:20200907094115). Firefox no longer crashes after printing the about:sessionrestore page with the given steps.