1662222 - Don't spin the event loop in nsPrintJob::DoCommonPrint when called by extensions

Status: RESOLVED FIXED

(Core :: Printing: Setup, task, P2)

Description

[Jonathan Watt [:jwatt]]

In https://phabricator.services.mozilla.com/D88703 I'm adding a settingsAreComplete check to avoid spinning the event loop to fetch settings from the parent process when the new print UI is enabled. To reduce risk for Beta uplifts I've added an extra printSilentOnSettings check there so that we do continue to spin the event loop for calls from extensions, in order to avoid changing behavior there. I'm pretty sure that won't cause extensions problems though, and we also need to stop spinning the event loop for them to get rid of that code. We should do that after we've finished churning this code with patches we may want to uplift to Beta 81.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1662222. Don't spin a nested event loop in nsPrintJob::DoCommonPrint when called by extensions. r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/268968002315
Don't spin a nested event loop in nsPrintJob::DoCommonPrint when called by extensions. r=emilio

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/268968002315