1662331 - Use sheetCount rather than calculated the number of rendered pages

Status: RESOLVED FIXED

(Toolkit :: Printing, task, P2)

Description

[Mark Striemer [:mstriemer]]

The printPreview promise API returns to us the sheetCount which isn't currently being used, but could be used instead of doing page range calculations on our own.

We'll definitely want to do this before pages per sheet is ready (bug 1631452) and the math on our page range calculation will become incorrect.

While making this change it might be nice to remove the page-count event and instead put totalPageCount and sheetCount on the view settings object.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

[Moving front-end printing v82 bugs to v83.]

Comment 2

[Mark Striemer [:mstriemer]]

This is needed for the pages per sheet work, moving back to 84

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Bug 1662331 - Part 1: Use the sheetCount from printPreview directly r?emalysz

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: Bug 1662331 - Part 2: Rename numPages to sheetCount r?sfoster

Depends on D95332

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8204a321ed4c
Part 1: Use the sheetCount from printPreview directly r=emalysz
https://hg.mozilla.org/integration/autoland/rev/59d94c9d9925
Part 2: Rename numPages to sheetCount r=sfoster

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8204a321ed4c
https://hg.mozilla.org/mozilla-central/rev/59d94c9d9925

Comment 7

[Anca Soncutean, Desktop QA]

Nothing actionable for qa, flag removed