Open Bug 1662344 Opened 5 years ago Updated 6 months ago

mark some MIR instructions as guard

Categories

(Core :: JavaScript Engine: JIT, task, P3)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
task

Tracking

()

People

(Reporter: jandem, Unassigned)

References

(Blocks 1 open bug)

Details

anba noticed some MIR instructions do type guards and aren't marked as guard (eliminating them could result in correctness bugs if behavior is observable after a bailout).

GuardToInt32Index (uses MToNumberInt32), GuardToInt32ModUint32 (uses MTruncateToInt32), and GuardToUint8Clamped (uses MClampToUint8)

From the list only MClampToUint8 is not annotate with setGuard calls in the constructor.

Blocks: sm-opt-jits
No longer blocks: CacheIRTranspiler
Priority: P2 → P3
Summary: Warp: mark some MIR instructions as guard → mark some MIR instructions as guard
You need to log in before you can comment on or make changes to this bug.