1662362 - Record STATE_UNBLOCKED_UNSAFE_CONTENT event to content blocking log when unblock API of URL Classifier is called

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P1)

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1662362 - Record STATE_UNBLOCKED_UNSAFE_CONTENT event to content blocking log when unblock API of URL Classifier is called

Comment 2

[Dimi Lee [:dimi]]

Hi Tim,
Can you help take this over? thanks!

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

The solution in this patch somewhat works, but one thing that is unsolved is that the compounded state will not allow for a consumer to check if a resource was blocked by a specific category of content blocking via this channel unblocking path, without looking at the full content blocking log.

This flaw is a commonly occurring theme due to the way content blocking state is designed. I'm not sure if there's a better way to do this at the moment. We already have some bugs where a category is shown as "blocked" when there's actually nothing in that category present in the content blocking log due to making inferences like this.

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1662362 - Treat shimmed resources as blocked in protections panel category subviews. r=timhuang!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ae204986ebc
Record STATE_UNBLOCKED_UNSAFE_CONTENT event to content blocking log when unblock API of URL Classifier is called r=nhnt11,timhuang
https://hg.mozilla.org/integration/autoland/rev/bb98f4ba93ed
Treat shimmed resources as blocked in protections panel category subviews. r=timhuang

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2ae204986ebc
https://hg.mozilla.org/mozilla-central/rev/bb98f4ba93ed