1662406 - jit-tests: change "wasm-compiler=ion" to "=optimized" and use Cranelift on aarch64

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P1)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Follow up from bug 1660944, see bug 1660944 comment 8 and bug 1660944 comment 10.

Comment 1

[Lars T Hansen [:lth]]

My bad I think, should be "optimizing" not "optimized".

Edit: OIC, using "optimized" to mirror the tier name is intentional. I don't think that is right - code is "optimized" hence the tier name but the compiler is definitely "optimizing". At the same time it may be easy to pick either name when writing down the switch. In the spirit of compromise we could accept both...

Comment 2

[Lars T Hansen [:lth]]

P1 b/c cranelift aarch64. Assigning b/c no P1 without assignee, but if you don't have time just say so and I'll take it myself.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1662406: Replace `--wasm-compiler=ion` by `--wasm-compiler=optimizing`; r?lth

This introduces two (2) new options for --wasm-compiler:

• optimizing (or equivalently, optimized), which uses the optimizing compiler
  for this platform (as of the day of writing: ion everywhere but on aarch64
  where cranelift is used)
• baseline+optimizing (or equivalently, baseline+optimized), which is the
  default.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7bace8a55722
Replace `--wasm-compiler=ion` by `--wasm-compiler=optimizing`; r=lth

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7bace8a55722